Skip to content

Conversation

ETOgaosion
Copy link
Collaborator

Checklist Before Starting

  • Search for similar PR(s).

What does this PR do?

Wandb Timing: Add more detailed timing of gen_sequence and weights resharding.

High-Level Design

Demonstrate the high-level design if this PR is complex.

Specific Changes

List the specific changes.

API

Demonstrate how the API changes if any.

Usage Example

Provide usage example(s) for easier usage.

# Add code snippet or script demonstrating how to use this 

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluatuion results, etc.

Additional Info.

  • Issue Number: Fixes issue # or discussion # if any.
  • Training: [Note which backend this PR will affect: FSDP, Megatron, both, or none]
  • Inference: [Note which backend this PR will affect: vLLM, SGLang, both, or none]

Checklist Before Submitting

  • Read the Contribute Guide.
  • Apply pre-commit checks.
  • Add [BREAKING] to the PR title if it breaks any API.
  • Update the documentation about your changes in the docs.
  • New CI unit test(s) are added to cover the code path.
  • Rely on existing unit tests on CI that covers the code path.

@@ -0,0 +1,39 @@
# Copyright 2024 Bytedance Ltd. and/or its affiliates
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we move this to verl/utils/debug/performance.py?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, make sense to me, didn't find this in the same directory.

@vermouth1992
Copy link
Collaborator

LGTM

@ETOgaosion ETOgaosion force-pushed the add_weights_transfer_timing branch from 5c18a45 to c77ffca Compare June 5, 2025 12:51
@ETOgaosion ETOgaosion force-pushed the add_weights_transfer_timing branch from 85dc28e to 3788fc2 Compare June 5, 2025 17:26
@vermouth1992 vermouth1992 merged commit 70bd3d3 into volcengine:main Jun 6, 2025
36 checks passed
yellowbee686 pushed a commit to yellowbee686/verl that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants