-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add DeepSeek 671B GRPO example #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2025
working at mcore 0.12.0, would hang if below this version
ccclyu
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! could you also add training curve like wandb link in the PR description for reference? Thanks!
vermouth1992
approved these changes
Jun 5, 2025
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Jun 6, 2025
### Checklist Before Starting - [x] Search for similar PR(s). ### What does this PR do? Add an example for DeepSeek 671B GRPO ### Specific Changes - Need volcengine#1694 - Set `torch._dynamo.config.suppress_errors = True` at entrypoint, if ``` ray.exceptions.RaySystemError: System error: Failed to unpickle serialized exception traceback: Traceback (most recent call last): File "/usr/local/lib/python3.10/dist-packages/ray/exceptions.py", line 46, in from_ray_exception return pickle.loads(ray_exception.serialized_exception) TypeError: BackendCompilerFailed.__init__() missing 1 required positional argument: 'inner_exception' ``` ### Additional Info. - vllm as backend, sglang working in process (sgl-project/sglang#6762). Merged when both backends are ready. - For DeepSeek-V3-0324 at `gsm8k`, the reward starts from 0.8 and saturated at around 0.95 using only 3 steps. - Memory peaks around 90GB during actor update (1.5k input + 2.5k output), consider using TP/ETP for a lower requirement. - For gsm8k training using this yaml,  ### Checklist Before Submitting - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add CI test(s) if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist Before Starting
What does this PR do?
Add an example for DeepSeek 671B GRPO
Specific Changes
torch._dynamo.config.suppress_errors = True
at entrypoint, ifAdditional Info.
update_weights_from_tensor
sgl-project/sglang#6762). Merged when both backends are ready.gsm8k
, the reward starts from 0.8 and saturated at around 0.95 using only 3 steps.Checklist Before Submitting
[BREAKING]
to the PR title if it breaks any API.