[ray] fix: error when bind async method in create_colocated_worker #1745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist Before Starting
What does this PR do?
fix a bug when register async method to fsdp worker.
When use async method in fsdp worker, it fails with:
/usr/local/lib/python3.10/dist-packages/ray/_private/worker.py:919: RayTaskError(TypeError)
You can reproduce this error in tests/ray_gpu/test_colocated_workers.py with async method.
High-Level Design
wrap async method if the original method is coroutine
Specific Changes
changed _bind_workers_method_to_parent
API
n\a
Usage Example
tests/ray_gpu/test_colocated_workers.py
Test
tests/ray_gpu/test_colocated_workers.py
Additional Info.
Checklist Before Submitting
[BREAKING]
to the PR title if it breaks any API.