Skip to content

Conversation

U-rara
Copy link
Contributor

@U-rara U-rara commented May 12, 2025

Checklist Before Starting

  • Search for similar PR(s).

What does this PR do?

In Async rollout, AsyncOpenAI has a default 600-second timeout, which can lead to timeouts during longer inference. See details at #1138 (comment).

High-Level Design

See details at #1138 (comment).

Specific Changes

See details at #1138 (comment).

API

Demonstrate how the API changes if any.

Usage Example

Provide usage example(s) for easier usage.

# Add code snippet or script demonstrating how to use this 

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluatuion results, etc.

Additional Info.

  • Issue Number: Fixes issue # or discussion # if any.
  • Training: [Note which backend this PR will affect: FSDP, Megatron, both, or none]
  • Inference: [Note which backend this PR will affect: vLLM, SGLang, both, or none]

Checklist Before Submitting

  • Read the Contribute Guide.
  • Apply pre-commit checks.
  • Add [BREAKING] to the PR title if it breaks any API.
  • Update the documentation about your changes in the docs.
  • Add CI test(s) if neccessary.

@casper-hansen
Copy link
Contributor

Great bugfix! I think a lot of users are likely to run into this use when using e.g. 32k completion length.

@wuxibin89 wuxibin89 merged commit cb1adda into volcengine:main May 12, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants