[sglang] Fix tool format and response position ids padding in AsyncSGLangRollout #1475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist Before Starting
What does this PR do?
Resolved the tool formatting issue: Previously, arguments were stored as strings, causing iterative addition of
\\
due to multiple calls tojson.dumps
.Fixed the
response_position_ids
mismatch betweengenerate_sequences
andgenerate_sequences_with_tools
: In the earlier implementation,generate_sequences_with_tools
used zero padding for positions whereattention mask == 0
, which resulted in NaN values during the training phase.Specific Changes
OpenAIFunctionCallSchema
, to store converted tool calls.AsyncSGLangRollout
tool to skip non-dict type arguments instead of handling any string at the arguments position.response_position_ids
ingenerate_sequences_with_tools
with the behavior ofgenerate_sequences
.API
execute
interface of the tool to directly acceptdict[str, Any]
instead of a JSON string.Usage Example
# Add code snippet or script demonstrating how to use this
Test
Additional Info.
Checklist Before Submitting
[BREAKING]
to the PR title if it breaks any API.