Automated cherry pick of #4422: Move kube-scheduler related metrics initilization to server.go to avoid panic #4461
Conversation
…id panic Signed-off-by: jessestutler <chenzicong4@huawei.com>
There was a problem hiding this comment.
Summary of Changes
Hello @JesseStutler, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated cherry-pick that addresses a potential panic in the kube-scheduler by refactoring how Kubernetes scheduler-related metrics are initialized. It ensures that critical metrics, such as Goroutines, are properly set up at startup, especially when metrics are enabled, thereby improving the scheduler's stability. A new test file was also added, which likely highlighted the need for this fix.
Highlights
- Metrics Initialization Refactor: Centralized the initialization of Kubernetes scheduler-related metrics, specifically
Goroutines, into a newInitKubeSchedulerRelatedMetricsfunction withinpkg/scheduler/metrics/metrics.go. This function is now explicitly called when metrics are enabled. - Panic Prevention: The primary goal of this change is to prevent panics by ensuring that necessary Kubernetes scheduler metrics are properly initialized before use, particularly when running the scheduler.
- Code Cleanup & Test Addition: Removed redundant
metrics.Register()calls frompkg/scheduler/plugins/predicates/predicates.goandpkg/scheduler/uthelper/helper.go. A new test file,pkg/scheduler/plugins/nodeorder/nodeorder_test.go, was added, which likely exposed the original panic condition and now relies on the new initialization.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
cc @lowang-bh @hwdef |
|
/lgtm |
Cherry pick of #4422 on release-1.12.
#4422: Move kube-scheduler related metrics initilization to server.go to avoid panic
For details on the cherry pick process, see the cherry picks page.