Skip to content

BUG/CLN: Refactor model abstraction so we don't subclass LightningModel, to fix loss logging #737

@NickleDave

Description

@NickleDave

When we subclass LightningModel it seems to break logging, see #726.

I am at least able to get better logging -- still does some weird things -- if I remove all the magic sub-classing of vak.models.base.Model and instead define model families that each separately sub-class LightingModule, e.g. FrameClassificationModel(lightning.LightningModule).

This actually can be fine for us; we define a per-family class, and we refactor the logic we have now for converting definitions into models such that it instantiates the components of a model and then passes those components into the model-family class when instantiating it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions