Skip to content

Conversation

abhishek44sharma
Copy link
Contributor

This is a pull request template. Please provide the following information to
help us review your pull request.

Please remove placeholder text (including this text)and replace it with your
own content.

Title of the Pull Request

Description

Please provide a summary of your changes here. Include the purpose of the change
and any relevant issues this PR addresses.

Changes

List the major changes you have made in bullet points:

  • Change 1
  • Change 2
  • Change 3

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Additional Comments

Include any additional comments or context about the PR here.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project's license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

Signed-off-by: Abhishek Sharma <abhishek44sharma@gmail.com>
@v0lkan
Copy link
Collaborator

v0lkan commented Nov 12, 2024

Thanks for your contribution @abhishek44sharma 🚀 .

I'll check it out tomorrow morning…ish pacific time.

Cheers.

Copy link
Collaborator

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🌮 .

Thanks for all the tests 🙏 .

I'll merge them in and run the tests in the build server too.

@v0lkan v0lkan merged commit 10ea8e5 into main Nov 12, 2024
@v0lkan v0lkan deleted the topic/abhishek/UT branch November 12, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants