Refactor: fix potential panic & refactor some code #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@canack, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
v0lkan
reviewed
Aug 27, 2024
v0lkan
reviewed
Aug 27, 2024
v0lkan
reviewed
Aug 27, 2024
v0lkan
reviewed
Aug 27, 2024
|
Thanks for your contributions @canack Can you also sign-off your commits for us to be able to merge them in. Best. |
Signed-off-by: Engin Acikgoz <engin.acikgoz@protonmail.com>
Signed-off-by: Engin Acikgoz <engin.acikgoz@protonmail.com>
Signed-off-by: Engin Acikgoz <engin.acikgoz@protonmail.com>
Signed-off-by: Engin Acikgoz <engin.acikgoz@protonmail.com>
This reverts commit d0b1eaf. Signed-off-by: Engin Acikgoz <engin.acikgoz@protonmail.com>
|
Landed. Thanks for your contributions @canack . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've made few changes, I hope it makes secrets-manager better 🧪