Skip to content

Conversation

v0lkan
Copy link
Collaborator

@v0lkan v0lkan commented Aug 3, 2024

About

Due to a missing root key getter, keygen could not decrypt secrets.

This patch fixes it.

Changes

  • in the entry point ./cmd/main.go of VSecM KeyGen, we now read the secret keys from the saved file and storing them in memory before starting the secret decryption process.

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project's license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

v0lkan added 2 commits August 2, 2024 17:45
due to a missing root key getter, keygen was not able to decrypt
secrets. This patch fixes it.

Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
add the key parsing logic into block that uses the key.

Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
@v0lkan v0lkan self-assigned this Aug 3, 2024
@v0lkan v0lkan requested a review from BulldromeQ as a code owner August 3, 2024 03:14
@v0lkan
Copy link
Collaborator Author

v0lkan commented Aug 3, 2024

I need to run the tests one more time; and then I'll merge.

@v0lkan
Copy link
Collaborator Author

v0lkan commented Aug 3, 2024

Regression has been fixed, and all tests passing.

Landing this one.

@v0lkan v0lkan merged commit 2ebdcdc into main Aug 3, 2024
@v0lkan v0lkan deleted the ovolkan/keygen-fix branch August 3, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant