Skip to content

[Bugfix] Fix missing placeholder in logger debug #21280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

[Bugfix] Fix missing placeholder in logger debug #21280

merged 1 commit into from
Jul 21, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jul 21, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Fix the error log shown in model tests:

[2025-07-21T05:11:22Z] Traceback (most recent call last):
[2025-07-21T05:11:22Z]   File "/usr/lib/python3.12/logging/__init__.py", line 1160, in emit
[2025-07-21T05:11:22Z]     msg = self.format(record)
[2025-07-21T05:11:22Z]           ^^^^^^^^^^^^^^^^^^^
[2025-07-21T05:11:22Z]   File "/usr/lib/python3.12/logging/__init__.py", line 999, in format
[2025-07-21T05:11:22Z]     return fmt.format(record)
[2025-07-21T05:11:22Z]            ^^^^^^^^^^^^^^^^^^
[2025-07-21T05:11:22Z]   File "/usr/local/lib/python3.12/dist-packages/vllm/logging_utils/formatter.py", line 14, in format
[2025-07-21T05:11:22Z]     msg = logging.Formatter.format(self, record)
[2025-07-21T05:11:22Z]           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[2025-07-21T05:11:22Z]   File "/usr/lib/python3.12/logging/__init__.py", line 703, in format
[2025-07-21T05:11:22Z]     record.message = record.getMessage()
[2025-07-21T05:11:22Z]                      ^^^^^^^^^^^^^^^^^^^
[2025-07-21T05:11:22Z]   File "/usr/lib/python3.12/logging/__init__.py", line 392, in getMessage
[2025-07-21T05:11:22Z]     msg = msg % self.args
[2025-07-21T05:11:22Z]           ~~~~^~~~~~~~~~~
[2025-07-21T05:11:22Z] TypeError: not all arguments converted during string formatting

Test Plan

Test Result

(Optional) Documentation Update

@DarkLight1337
[Bugfix] Fix missing placeholder in logger debug
8a4e32f 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 21, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a TypeError in a debug log statement by adding the missing format specifier. The change is correct and idiomatic, using lazy formatting for the log message. This effectively resolves the bug and cleans up the logs. The change is well-contained and looks good to merge.

@vllm-bot vllm-bot merged commit 378d33c into vllm-project:main Jul 21, 2025
10 of 12 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-debug branch July 21, 2025 05:50
LyrisZhong pushed a commit to LyrisZhong/vllm that referenced this pull request Jul 23, 2025
@DarkLight1337 @LyrisZhong
[Bugfix] Fix missing placeholder in logger debug (vllm-project#21280)
39e3448 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
@DarkLight1337 @avigny
[Bugfix] Fix missing placeholder in logger debug (vllm-project#21280)
5addbd9 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
@DarkLight1337 @x22x22
[Bugfix] Fix missing placeholder in logger debug (vllm-project#21280)
c3bdf27 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
@DarkLight1337
[Bugfix] Fix missing placeholder in logger debug (vllm-project#21280)
cfeb213 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
@DarkLight1337 @npanpaliya
[Bugfix] Fix missing placeholder in logger debug (vllm-project#21280)
9668bd2 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@DarkLight1337 @jinzhen-lin
[Bugfix] Fix missing placeholder in logger debug (vllm-project#21280)
c7c8668 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@DarkLight1337 @paulpak58
[Bugfix] Fix missing placeholder in logger debug (vllm-project#21280)
f22af94 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
@DarkLight1337 @taneem-ibrahim
[Bugfix] Fix missing placeholder in logger debug (vllm-project#21280)
35d00d7 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@DarkLight1337 @diegocastanibm
[Bugfix] Fix missing placeholder in logger debug (vllm-project#21280)
0c4cae1 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
@DarkLight1337 @epwalsh
[Bugfix] Fix missing placeholder in logger debug (vllm-project#21280)
e2fec13 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
@DarkLight1337 @googlercolin
[Bugfix] Fix missing placeholder in logger debug (vllm-project#21280)
5090a65 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@jeejeelee jeejeelee Awaiting requested review from jeejeelee

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @Isotr0py @vllm-bot