-
-
Notifications
You must be signed in to change notification settings - Fork 10k
[DP] Fix Prometheus Logging #21257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vllm-bot
merged 53 commits into
vllm-project:main
from
robertgshaw2-redhat:fix-prom-logging-in-dp-case
Jul 21, 2025
Merged
[DP] Fix Prometheus Logging #21257
vllm-bot
merged 53 commits into
vllm-project:main
from
robertgshaw2-redhat:fix-prom-logging-in-dp-case
Jul 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Signed-off-by: Robert Shaw <robshaw@redhat.com>
Signed-off-by: Robert Shaw <robshaw@redhat.com>
Signed-off-by: Robert Shaw <robshaw@redhat.com>
Signed-off-by: Robert Shaw <robshaw@redhat.com>
Signed-off-by: Robert Shaw <robshaw@redhat.com>
This pull request has merge conflicts that must be resolved before it can be |
1 task
4 tasks
Signed-off-by: Robert Shaw <robshaw@redhat.com>
Signed-off-by: Robert Shaw <robshaw@redhat.com>
Merging to unblock release |
4 tasks
I will do a retroactive review :) |
eicherseiji
added a commit
to eicherseiji/vllm
that referenced
this pull request
Jul 22, 2025
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
LyrisZhong
pushed a commit
to LyrisZhong/vllm
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com>
avigny
pushed a commit
to avigny/vllm
that referenced
this pull request
Jul 31, 2025
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
x22x22
pushed a commit
to x22x22/vllm
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com> Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92
pushed a commit
to Pradyun92/vllm
that referenced
this pull request
Aug 6, 2025
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com>
npanpaliya
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Aug 6, 2025
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com>
jinzhen-lin
pushed a commit
to jinzhen-lin/vllm
that referenced
this pull request
Aug 9, 2025
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58
pushed a commit
to paulpak58/vllm
that referenced
this pull request
Aug 13, 2025
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
taneem-ibrahim
pushed a commit
to taneem-ibrahim/vllm
that referenced
this pull request
Aug 14, 2025
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com>
diegocastanibm
pushed a commit
to diegocastanibm/vllm
that referenced
this pull request
Aug 15, 2025
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com>
googlercolin
pushed a commit
to googlercolin/vllm
that referenced
this pull request
Aug 29, 2025
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
PrometheusStatLogger
for eachEngineCore
. This appears okay on the surface, but what was happening is that only the finalEngineCore
would be able to log stats since we reset the Prometheus state in each constructorunregister_vllm_metrics
unregister_vllm_metrics
does not work, because we can only * create * the metrics once. We just want to have multiple labels for the same metric not multiple metricsStatLoggerMananger
to deal with this:PrometheusStatLogger
to enable logging from multiple engine coresAsyncLLM
only logs the metrics of the EngineCores that it is directly managingFollow up:
Test Plan
existing CI
justfile
Test Result
Sample:
just dp_a_internal_lb 8100 just dp_b_internal_lb 8100 just eval 8100 just metrics 8100
rank 0:
rank 1:
(Optional) Documentation Update