Skip to content

Conversation

yankay
Copy link
Contributor

@yankay yankay commented Jul 20, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Remove the modelscope!=1.15.0 version constraint from Docker build configurations.
This constraint was originally added in #5668 to resolve an issue specific to modelscope 1.15.0.
It can now be safely removed to simplify the code and improve readability because the issue has been addressed in newer releases.

Test Plan

Test Result

(Optional) Documentation Update

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jul 20, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up a version constraint for the modelscope package in the Dockerfiles, which is a good simplification. However, by removing the constraint entirely, the package is now unpinned. To ensure build reproducibility and prevent future breakages from new modelscope releases, I've recommended pinning the dependency to a known-good version or a safe version range.

@@ -510,7 +510,7 @@ RUN --mount=type=cache,target=/root/.cache/uv \
else \
BITSANDBYTES_VERSION="0.46.1"; \
fi; \
uv pip install --system accelerate hf_transfer 'modelscope!=1.15.0' "bitsandbytes>=${BITSANDBYTES_VERSION}" 'timm==0.9.10' boto3 runai-model-streamer runai-model-streamer[s3]
uv pip install --system accelerate hf_transfer modelscope "bitsandbytes>=${BITSANDBYTES_VERSION}" 'timm==0.9.10' boto3 runai-model-streamer runai-model-streamer[s3]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While removing the constraint for modelscope==1.15.0 is a good cleanup, leaving modelscope completely unpinned in a production Dockerfile can lead to non-reproducible builds and potential breakages in the future if a new version introduces breaking changes.

To improve stability, it's best practice to pin dependencies. Could you please consider pinning modelscope to a known good version range? For example, if versions greater than 1.15.0 are known to be stable, you could use a lower bound like >=1.15.1. This would prevent the problematic version while still allowing updates, but in a more controlled way. An even safer approach would be to pin to a specific known-good version, e.g., ==1.16.0.

    uv pip install --system accelerate hf_transfer 'modelscope>=1.15.1' "bitsandbytes>=${BITSANDBYTES_VERSION}" 'timm==0.9.10' boto3 runai-model-streamer runai-model-streamer[s3]

@@ -47,7 +47,7 @@ FROM vllm-base AS vllm-openai

# install additional dependencies for openai api server
RUN --mount=type=cache,target=/root/.cache/pip \
pip install accelerate hf_transfer pytest 'modelscope!=1.15.0'
pip install accelerate hf_transfer pytest modelscope
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similar to the other Dockerfile, leaving modelscope unpinned here could affect the stability and reproducibility of the build. A future release of modelscope with breaking changes could cause this build to fail.

To ensure the Docker image remains stable over time, could you pin modelscope to a known good version or at least a safe version range, for example, >=1.15.1?

    pip install accelerate hf_transfer pytest 'modelscope>=1.15.1'

@Isotr0py Isotr0py enabled auto-merge (squash) July 20, 2025 11:27
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 20, 2025
@simon-mo simon-mo disabled auto-merge July 21, 2025 03:12
@simon-mo simon-mo merged commit 8188196 into vllm-project:main Jul 21, 2025
108 of 110 checks passed
LyrisZhong pushed a commit to LyrisZhong/vllm that referenced this pull request Jul 23, 2025
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
…t#21243)

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
…t#21243)

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
…t#21243)

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
…t#21243)

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
…t#21243)

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants