[Misc] Add dummy maverick test #21199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Code Review
The code introduces a new test script to generate a smaller, dummy version of the Maverick model for testing purposes. There are two critical issues that would prevent the script from running correctly or would generate a broken model. The review includes suggestions to fix these issues.
Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: Ming Yang <minos.future@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: Ming Yang <minos.future@gmail.com>
Signed-off-by: Ming Yang <minos.future@gmail.com>
21a75f3 to
ac4541f
Compare
|
cc @houseroad |
Signed-off-by: Ming Yang <minos.future@gmail.com>
DarkLight1337
approved these changes
Jul 20, 2025
LyrisZhong
pushed a commit
to LyrisZhong/vllm
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
avigny
pushed a commit
to avigny/vllm
that referenced
this pull request
Jul 31, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
x22x22
pushed a commit
to x22x22/vllm
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92
pushed a commit
to Pradyun92/vllm
that referenced
this pull request
Aug 6, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
npanpaliya
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Aug 6, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
jinzhen-lin
pushed a commit
to jinzhen-lin/vllm
that referenced
this pull request
Aug 9, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58
pushed a commit
to paulpak58/vllm
that referenced
this pull request
Aug 13, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
taneem-ibrahim
pushed a commit
to taneem-ibrahim/vllm
that referenced
this pull request
Aug 14, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
diegocastanibm
pushed a commit
to diegocastanibm/vllm
that referenced
this pull request
Aug 15, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
googlercolin
pushed a commit
to googlercolin/vllm
that referenced
this pull request
Aug 29, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To improve test coverage for code paths used by maverick, with reduced hardware resource cost.
Targeting usage:
Non-goals:
Test Plan
pytest -s tests/models/test_maverick_serving.py
Test Result
passed UT
(Optional) Documentation Update