Skip to content

[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 required positional argument: 'use_ue8m0' for SM100 #21187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2025
Merged

[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 required positional argument: 'use_ue8m0' for SM100 #21187

merged 3 commits into from
Jul 19, 2025

Conversation

yewentao256
Copy link
Collaborator

@yewentao256 yewentao256 commented Jul 18, 2025 •
edited by github-actions bot
Loading

Purpose

deepseek-ai/DeepGEMM#112 merged

this pr fixes E TypeError: per_block_cast_to_fp8() missing 1 required positional argument: 'use_ue8m0'

Test

VLLM_USE_DEEP_GEMM=1 lm_eval   --model vllm   --model_args "pretrained=Qwen/Qwen3-30B-A3B-FP8,max_model_len=32768,enforce_eager=True"   --trust_remote_code   --tasks gsm8k   --num_fewshot 5   --batch_size auto
|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.8597|±  |0.0096|
|     |       |strict-match    |     5|exact_match|↑  |0.8961|±  |0.0084|

@yewentao256
fix for no attribute
c7a150f 
Signed-off-by: yewentao256 <zhyanwentao@126.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request fixes a TypeError by adding the missing 'use_ue8m0' argument to the per_block_cast_to_fp8 function call when using DeepGEMM on SM100. The review suggests making the use_ue8m0 parameter configurable for broader applicability.

@yewentao256 yewentao256 changed the title [Fix] Fix TypeError: per_block_cast_to_fp8() missing 1 required positional argument: 'use_ue8m0' for SM100 [Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 required positional argument: 'use_ue8m0' for SM100 Jul 18, 2025
mgoin
mgoin approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgoin mgoin enabled auto-merge (squash) July 18, 2025 15:03
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 18, 2025
@mgoin mgoin added the bug Something isn't working label Jul 18, 2025
@mgoin mgoin added this to the v0.10.0 milestone Jul 19, 2025
@vllm-bot vllm-bot merged commit 37bd8d6 into vllm-project:main Jul 19, 2025
54 of 57 checks passed
@yewentao256 yewentao256 deleted the wye-fix-B200-deepgemm-support branch July 19, 2025 13:06
hj-mistral pushed a commit to hj-mistral/vllm that referenced this pull request Jul 19, 2025
@yewentao256 @hj-mistral
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
72784a1 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: Himanshu Jaju <hj@mistral.ai>
LyrisZhong pushed a commit to LyrisZhong/vllm that referenced this pull request Jul 23, 2025
@yewentao256 @LyrisZhong
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
4076e0e 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
@yewentao256 @avigny
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
109903a 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
@yewentao256 @x22x22
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
01db8d6 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
@yewentao256
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
7c6ce4d 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
@yewentao256 @npanpaliya
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
7726a85 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@yewentao256 @jinzhen-lin
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
0c3457d 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@yewentao256 @paulpak58
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
c38bff3 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
@yewentao256 @taneem-ibrahim
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
1f8250a 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@yewentao256 @diegocastanibm
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
f47f286 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
@yewentao256 @epwalsh
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
725fb60 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
@yewentao256 @googlercolin
[Bug] DeepGemm: Fix TypeError: per_block_cast_to_fp8() missing 1 requ…
3c4e48a 
…ired positional argument: 'use_ue8m0' for SM100 (vllm-project#21187)

Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@houseroad houseroad houseroad approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yewentao256 @mgoin @houseroad @vllm-bot