-
-
Notifications
You must be signed in to change notification settings - Fork 10k
[CI] Update CODEOWNERS for vllm/compilation #21185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now I can stop cc'ing Luka all the time. Signed-off-by: Richard Zou <zou3519@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the CODEOWNERS file to include @ProExpertProg as a code owner for the /vllm/compilation directory. No specific style guide was provided, and the change appears straightforward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited for the big green checkmark above this ✅
Signed-off-by: Richard Zou <zou3519@gmail.com>
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: WorldExplored <srreyansh.sethi@gmail.com>
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: WorldExplored <srreyansh.sethi@gmail.com>
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: Himanshu Jaju <hj@mistral.ai>
Signed-off-by: Richard Zou <zou3519@gmail.com>
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: x22x22 <wadeking@qq.com>
Signed-off-by: Richard Zou <zou3519@gmail.com>
Signed-off-by: Richard Zou <zou3519@gmail.com>
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
Signed-off-by: Richard Zou <zou3519@gmail.com>
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Richard Zou <zou3519@gmail.com>
Signed-off-by: Richard Zou <zou3519@gmail.com>
Purpose
Now I can stop CC-ing Luka every time :)