Skip to content

[V0 deprecation] Remove V0 HPU backend #21131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 17, 2025
Merged

[V0 deprecation] Remove V0 HPU backend #21131

merged 8 commits into from
Jul 17, 2025

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Jul 17, 2025 •
edited
Loading

In vLLM V1, HPU is supported as a plugin.

@WoosukKwon
[V0 deprecation] Remove Neuron/HPU backends
9c9eabe 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@WoosukKwon
revert back neuron
82ed165 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@WoosukKwon
remove more
fea6190 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@WoosukKwon
Remove more HPU code
73aeee8 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jul 17, 2025
@WoosukKwon
remove dockerfile
cfeaece 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the V0 HPU backend, which is a significant and welcome cleanup. The changes are mostly removals of HPU-specific files and code paths, and they appear to be correct and self-contained.

I've identified one piece of dead code that was left behind in setup.py and have commented on it directly.

Additionally, my review of the entire codebase (not just the changed files) revealed a few other HPU-related leftovers that were not part of this pull request's diff. Since I cannot comment on files that were not modified, I'm listing them here for your consideration in a follow-up PR:

  • In vllm/config.py, the Device type hint still includes "hpu".
  • In vllm/envs.py, HPU-specific environment variables like VLLM_USE_HPU_CONTIGUOUS_CACHE_FETCH and VLLM_HPU_USE_DELAYED_SAMPLING are still defined.

Addressing these will complete the removal of the HPU backend. Overall, great work on this large-scale refactoring!

@WoosukKwon
remove more hpu
3cdc93e 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@WoosukKwon
HPU
ed4f652 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@simon-mo
Copy link
Collaborator

Please make corresponding update to docs.

@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 17, 2025
@WoosukKwon
Add ci back
dfd26bd 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@xuechendi
Copy link
Contributor

@kzawora-intel , please take a look.

@WoosukKwon WoosukKwon enabled auto-merge (squash) July 17, 2025 20:30
@hmellor hmellor moved this to In Progress in V0 Deprecation Jul 17, 2025
@WoosukKwon WoosukKwon disabled auto-merge July 17, 2025 23:37
@WoosukKwon WoosukKwon merged commit 4de7146 into main Jul 17, 2025
98 of 104 checks passed
@WoosukKwon WoosukKwon deleted the woosuk/remove-neuron-hpu branch July 17, 2025 23:37
@github-project-automation github-project-automation bot moved this from In Progress to Done in V0 Deprecation Jul 17, 2025
WorldExplored pushed a commit to nadathurv/vllm that referenced this pull request Jul 19, 2025
@WoosukKwon @WorldExplored
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
9178c11 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
WorldExplored pushed a commit to nadathurv/vllm that referenced this pull request Jul 19, 2025
@WoosukKwon @WorldExplored
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
e6eb6dd 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: WorldExplored <srreyansh.sethi@gmail.com>
hj-mistral pushed a commit to hj-mistral/vllm that referenced this pull request Jul 19, 2025
@WoosukKwon @hj-mistral
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
e5fca02 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Himanshu Jaju <hj@mistral.ai>
@kzawora-intel kzawora-intel mentioned this pull request Jul 21, 2025
Merged
LyrisZhong pushed a commit to LyrisZhong/vllm that referenced this pull request Jul 23, 2025
@WoosukKwon @LyrisZhong
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
88bfa85 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
@WoosukKwon @avigny
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
a3f2550 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
@WoosukKwon @x22x22
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
31997ca 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
@WoosukKwon
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
cbbf5e7 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
@WoosukKwon @npanpaliya
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
0142555 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@WoosukKwon @jinzhen-lin
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
f5e858b 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@WoosukKwon @paulpak58
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
525b593 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
@WoosukKwon @taneem-ibrahim
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
03385ee 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@WoosukKwon @diegocastanibm
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
9aac176 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
@hmellor hmellor mentioned this pull request Aug 26, 2025
Merged
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
@WoosukKwon @epwalsh
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
9df89de 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
@WoosukKwon @googlercolin
[V0 deprecation] Remove V0 HPU backend (vllm-project#21131)
4e319be 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

@jeejeelee jeejeelee Awaiting requested review from jeejeelee jeejeelee is a code owner

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123 zhuohan123 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@mgoin mgoin Awaiting requested review from mgoin

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth

@houseroad houseroad Awaiting requested review from houseroad

@hmellor hmellor Awaiting requested review from hmellor

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@xuechendi xuechendi xuechendi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
V0 Deprecation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WoosukKwon @simon-mo @xuechendi