Skip to content

[Misc] Fix PhiMoE expert mapping #21085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

[Misc] Fix PhiMoE expert mapping #21085

merged 1 commit into from
Jul 17, 2025

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Jul 17, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

@jeejeelee
Done
ea3d168 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@jeejeelee jeejeelee requested a review from Isotr0py July 17, 2025 01:43
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the expert parameter mapping for PhiMoE models to fix an issue with weight loading. The change replaces a generic mapping function with a model-specific get_expert_mapping method, which improves encapsulation and correctness. The changes appear correct and well-structured. No issues were found in the provided diff.

@Isotr0py Isotr0py enabled auto-merge (squash) July 17, 2025 01:57
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 17, 2025
@Isotr0py Isotr0py merged commit c5b8b59 into vllm-project:main Jul 17, 2025
79 of 81 checks passed
@jeejeelee jeejeelee deleted the fix-phimoe-mapping branch July 17, 2025 06:11
hj-mistral pushed a commit to hj-mistral/vllm that referenced this pull request Jul 19, 2025
@jeejeelee @hj-mistral
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
4abb6aa 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Himanshu Jaju <hj@mistral.ai>
LyrisZhong pushed a commit to LyrisZhong/vllm that referenced this pull request Jul 23, 2025
@jeejeelee @LyrisZhong
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
268289d 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
@jeejeelee @avigny
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
1c13302 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
@jeejeelee @x22x22
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
41b0266 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
@jeejeelee
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
655c3ef 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
@jeejeelee @npanpaliya
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
c2a1957 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@jeejeelee @jinzhen-lin
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
6449ee8 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@jeejeelee @paulpak58
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
ae3cd29 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
@jeejeelee @taneem-ibrahim
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
41b4d11 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@jeejeelee @diegocastanibm
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
5464a65 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
@jeejeelee @epwalsh
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
22cecaf 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
@jeejeelee @googlercolin
[Misc] Fix PhiMoE expert mapping (vllm-project#21085)
06d61bf 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeejeelee @Isotr0py