Skip to content

[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile #21013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2025
Merged

[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile #21013

merged 2 commits into from
Jul 17, 2025

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Jul 15, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

@mgoin
Allow FlashInfer to be built in the ARM CUDA Dockerfile
2bd00be 
Signed-off-by: mgoin <mgoin64@gmail.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jul 15, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables building FlashInfer for ARM platforms in the Dockerfile. I've identified a high-severity issue related to build efficiency due to the broad set of CUDA architectures used for ARM builds. I've also identified an opportunity to improve code readability by defining the BITSANDBYTES_VERSION variable outside the conditional statement.

@mgoin
Indent
625706d 
Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 16, 2025
@vllm-bot vllm-bot merged commit a50d918 into vllm-project:main Jul 17, 2025
105 of 108 checks passed
hj-mistral pushed a commit to hj-mistral/vllm that referenced this pull request Jul 19, 2025
@mgoin @hj-mistral
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
31c7817 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Himanshu Jaju <hj@mistral.ai>
LyrisZhong pushed a commit to LyrisZhong/vllm that referenced this pull request Jul 23, 2025
@mgoin @LyrisZhong
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
681aed6 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
@mgoin @avigny
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
56cda86 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
@mgoin @x22x22
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
c3f13bc 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
@mgoin
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
47ede2d 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
@mgoin @npanpaliya
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
a164aee 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@mgoin @jinzhen-lin
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
50b37cb 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@mgoin @paulpak58
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
5f07085 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
@mgoin @taneem-ibrahim
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
3dbb0d4 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@mgoin @diegocastanibm
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
eade260 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
@mgoin @epwalsh
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
d09262a 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
@mgoin @googlercolin
[Docker] Allow FlashInfer to be built in the ARM CUDA Dockerfile (vll…
5752b48 
…m-project#21013)

Signed-off-by: mgoin <mgoin64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgoin @DarkLight1337 @vllm-bot