[PD] add test for chat completions endpoint #21925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

vllm-bot merged 1 commit into vllm-project:main from Abirdcfly:addtest

Aug 4, 2025

Contributor

Abirdcfly commented Jul 30, 2025 •

edited by github-actions bot

Loading

Essential Elements of an Effective PR Description Checklist

The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
The test plan, such as providing test command.
The test results, such as pasting the results comparison before and after, or e2e results
(Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

For #21841 (comment)

Test Plan

Test Result

(Optional) Documentation Update

github-actions bot commented Jul 30, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

gemini-code-assist bot reviewed

View reviewed changes

Contributor

gemini-code-assist bot left a comment

Code Review

This pull request adds a test for the chat completions endpoint within the prefill/decode disaggregation testing framework. The changes correctly adapt the test infrastructure to handle the max_completion_tokens parameter used by the chat completions API. The new test logic properly alternates between the completions and chat completions endpoints. The implementation is clean and correct. I have no suggestions for improvement.

mergify bot added the v1 label

Abirdcfly force-pushed the addtest branch from ddbebf9 to f368a24 Compare

July 30, 2025 11:11


          [PD] add test for chat completions endpoint

e940266

Signed-off-by: Abirdcfly <fp544037857@gmail.com>

Abirdcfly force-pushed the addtest branch from f368a24 to e940266 Compare

July 30, 2025 13:13

Abirdcfly marked this pull request as ready for review

July 30, 2025 13:58

DarkLight1337 approved these changes

View reviewed changes

Member

DarkLight1337 left a comment

Thanks

DarkLight1337 enabled auto-merge (squash)

August 3, 2025 12:31

github-actions bot added the ready label

vllm-bot merged commit 0d7db16 into vllm-project:main

52 of 54 checks passed

Abirdcfly deleted the addtest branch

August 4, 2025 03:10

juuice-lee pushed a commit to juuice-lee/vllm-moe.code that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

6d34efb

Signed-off-by: Abirdcfly <fp544037857@gmail.com>

x22x22 pushed a commit to x22x22/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

f3fe3b7

Signed-off-by: Abirdcfly <fp544037857@gmail.com>

x22x22 pushed a commit to x22x22/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

7b76e11

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Signed-off-by: x22x22 <wadeking@qq.com>

x22x22 pushed a commit to x22x22/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

cf0f7b8

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Signed-off-by: x22x22 <wadeking@qq.com>

npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

a7a279a

Signed-off-by: Abirdcfly <fp544037857@gmail.com>

jingyu-ml pushed a commit to jingyu-ml/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

21117ce

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Signed-off-by: jingyu <jingyu@omniml.ai>

jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

a2b02eb

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>

noamgat pushed a commit to noamgat/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

f0f8c33

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Signed-off-by: Noam Gat <noamgat@gmail.com>

yyihuang pushed a commit to yyihuang/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

c08a8b7

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Signed-off-by: Avery Yingyi Huang <yingyihuang2000@outlook.com>

paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

0d5105f

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>

taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

68bb7c5

Signed-off-by: Abirdcfly <fp544037857@gmail.com>

BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

fa18fed

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Signed-off-by: Boyuan Feng <boyuan@meta.com>

diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

a49324e

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>

epwalsh pushed a commit to epwalsh/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

cd4b65c

Signed-off-by: Abirdcfly <fp544037857@gmail.com>

zhewenl pushed a commit to zhewenl/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

3a7c28a

Signed-off-by: Abirdcfly <fp544037857@gmail.com>

googlercolin pushed a commit to googlercolin/vllm that referenced this pull request


          [PD] add test for chat completions endpoint (vllm-project#21925)

49da9dc

Signed-off-by: Abirdcfly <fp544037857@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels