[`Ernie 4.5`] Name Change for Base 0.3B Model #21735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

DarkLight1337 merged 3 commits into vllm-project:main from vasqu:ernie-name-change

Jul 28, 2025

Contributor

vasqu commented Jul 28, 2025 •

edited by github-actions bot

Loading

Internally discussed with baidu/ernie team to have the name change from Ernie4_5_For... to Ernie4_5For...

Relevant hub PRs that need to be merged before:

cc @ArthurZucker


          ernie name change

f01e322

Signed-off-by: vasqu <antonprogamer@gmail.com>

vasqu requested review from hmellor, DarkLight1337 and ywang96 as code owners

July 28, 2025 09:14

gemini-code-assist bot reviewed

View reviewed changes

Contributor

gemini-code-assist bot left a comment

Code Review

This pull request refactors the Ernie4_5_ForCausalLM model to Ernie4_5ForCausalLM for consistency. The changes are applied across documentation, tests, and model definition files. However, I found a critical issue in the model registry where a reference to the old class name was missed. This would prevent the model from loading correctly and must be fixed.

mergify bot added documentation new-model labels

vasqu commented

View reviewed changes

docs/models/supported_models.md Outdated Show resolved Hide resolved

DarkLight1337 reviewed

View reviewed changes

docs/models/supported_models.md Show resolved Hide resolved

vasqu and others added 2 commits

July 28, 2025 11:21


          try empty commit with precommit

bdaaeda

Signed-off-by: vasqu <antonprogamer@gmail.com>


          Revert formatting changes

5ea8f2e

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>

DarkLight1337 approved these changes

View reviewed changes

DarkLight1337 enabled auto-merge (squash)

July 28, 2025 09:27

DarkLight1337 added ready and removed new-model labels

mergify bot added the new-model label

github-actions bot commented Jul 28, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

DarkLight1337 merged commit 656c24f into vllm-project:main

67 of 68 checks passed

vasqu deleted the ernie-name-change branch

July 28, 2025 13:40

liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

8f12933

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

HsChen-sys pushed a commit to HsChen-sys/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

0380da9

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

wenscarl pushed a commit to wenscarl/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

3ab7adf

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: shuw <shuw@nvidia.com>

x22x22 pushed a commit to x22x22/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

d670f80

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: x22x22 <wadeking@qq.com>

Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

4b2f1ea

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

ad74b0e

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>

paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

fef1b55

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Paul Pak <paulpak58@gmail.com>

taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

a4c6216

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

5c7c796

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Boyuan Feng <boyuan@meta.com>

diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

d425f47

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>

jinyouzhi pushed a commit to jinyouzhi/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

3a6e903

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

jinyouzhi pushed a commit to jinyouzhi/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

c0c75de

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

jinyouzhi mentioned this pull request

Porting ERNIE 4.5 and ERNIE 4.5 MoE model support HabanaAI/vllm-fork#1779

Merged

czhu15 pushed a commit to HabanaAI/vllm-fork that referenced this pull request


          Porting ERNIE 4.5 and ERNIE 4.5 MoE model support (#1779)

e502a28

Enable ERNIE 4.5 series text generation models including Dense and MoE. 

This PR contains:
- cherry-pick vllm-project#20220
- bugfix vllm-project#21735 (name mistake)

then validate on

- [ERNIE-4.5-0.3B-PT](https://huggingface.co/baidu/ERNIE-4.5-0.3B-PT)
-
[ERNIE-4.5-21B-A3B-PT](https://huggingface.co/baidu/ERNIE-4.5-21B-A3B-PT)

@Wei-Lin-Intel

---------

Signed-off-by: wangyafeng <wangyafeng@baidu.com>
Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: CSWYF3634076 <58356743+CSWYF3634076@users.noreply.github.com>
Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

epwalsh pushed a commit to epwalsh/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

zhewenl pushed a commit to zhewenl/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

4b9a365

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

googlercolin pushed a commit to googlercolin/vllm that referenced this pull request


          [Ernie 4.5] Name Change for Base 0.3B Model (vllm-project#21735)

f60505c

Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

czhu15 pushed a commit to HabanaAI/vllm-fork that referenced this pull request


          Porting ERNIE 4.5 and ERNIE 4.5 MoE model support (#1779)

5cbb6a1

Enable ERNIE 4.5 series text generation models including Dense and MoE. 

This PR contains:
- cherry-pick vllm-project#20220
- bugfix vllm-project#21735 (name mistake)

then validate on

- [ERNIE-4.5-0.3B-PT](https://huggingface.co/baidu/ERNIE-4.5-0.3B-PT)
-
[ERNIE-4.5-21B-A3B-PT](https://huggingface.co/baidu/ERNIE-4.5-21B-A3B-PT)

@Wei-Lin-Intel

---------

Signed-off-by: wangyafeng <wangyafeng@baidu.com>
Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: CSWYF3634076 <58356743+CSWYF3634076@users.noreply.github.com>
Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

czhu15 pushed a commit to HabanaAI/vllm-fork that referenced this pull request


          Porting ERNIE 4.5 and ERNIE 4.5 MoE model support (#1779)

c3d983f

Enable ERNIE 4.5 series text generation models including Dense and MoE. 

This PR contains:
- cherry-pick vllm-project#20220
- bugfix vllm-project#21735 (name mistake)

then validate on

- [ERNIE-4.5-0.3B-PT](https://huggingface.co/baidu/ERNIE-4.5-0.3B-PT)
-
[ERNIE-4.5-21B-A3B-PT](https://huggingface.co/baidu/ERNIE-4.5-21B-A3B-PT)

@Wei-Lin-Intel

---------

Signed-off-by: wangyafeng <wangyafeng@baidu.com>
Signed-off-by: vasqu <antonprogamer@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: CSWYF3634076 <58356743+CSWYF3634076@users.noreply.github.com>
Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DarkLight1337 DarkLight1337 approved these changes

hmellor Awaiting requested review from hmellor hmellor is a code owner

ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

+1 more reviewer

gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Labels

documentation new-model ready