[CI] Trimming some failing test groups from AMDPRODUCTION. #20390
Conversation
Update test-pipeline.yaml Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Summary of Changes
Hello @Alexei-V-Ivanov-AMD, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to streamline our CI pipeline by removing certain test groups from execution on the amdproduction hardware mirror. The intent is to address issues with these tests currently failing on that specific hardware, as indicated by the PR title, allowing the amdproduction pipeline to pass without these specific failures.
Highlights
- CI Configuration Update: I've updated the
.buildkite/test-pipeline.yamlfile to remove theamdproductionhardware mirror from several test groups. This change specifically affects the 'Regression Test', 'Engine Test', 'PyTorch Compilation Unit Tests', 'Tensorizer Test', 'Basic Models Test', and 'Multi-Modal Models Test (Extended) 3' steps.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request disables several test groups on the amdproduction hardware mirror, presumably to fix failing CI jobs. The changes are straightforward. My main feedback is to add comments to each disabled test group, explaining the reason and linking to a tracking issue if one exists. This is crucial for maintainability, ensuring these tests are re-enabled once the underlying issues are resolved.
| @@ -215,7 +215,7 @@ steps: | |||
| ##### 1 GPU test ##### | |||
|
|
|||
| - label: Regression Test # 5min | |||
| mirror_hardwares: [amdexperimental, amdproduction] | |||
| mirror_hardwares: [amdexperimental] | |||
There was a problem hiding this comment.
While disabling failing tests on amdproduction is a practical step to unblock the CI, it's important to track this change to ensure it's not permanent. Could you add an inline comment with a brief explanation and a link to a tracking issue (if available)? This will help prevent the disabled test suite from being forgotten and provide context for future maintainers.
mirror_hardwares: [amdexperimental] # Temporarily disabled on amdproduction due to failing tests. See issue #<ISSUE_NUMBER>.
| @@ -225,7 +225,7 @@ steps: | |||
| working_dir: "/vllm-workspace/tests" # optional | |||
|
|
|||
| - label: Engine Test # 10min | |||
| mirror_hardwares: [amdexperimental, amdproduction] | |||
| mirror_hardwares: [amdexperimental] | |||
There was a problem hiding this comment.
While disabling failing tests on amdproduction is a practical step to unblock the CI, it's important to track this change to ensure it's not permanent. Could you add an inline comment with a brief explanation and a link to a tracking issue (if available)? This will help prevent the disabled test suite from being forgotten and provide context for future maintainers.
mirror_hardwares: [amdexperimental] # Temporarily disabled on amdproduction due to failing tests. See issue #<ISSUE_NUMBER>.
| @@ -338,7 +338,7 @@ steps: | |||
| parallelism: 4 | |||
|
|
|||
| - label: PyTorch Compilation Unit Tests | |||
| mirror_hardwares: [amdexperimental, amdproduction] | |||
| mirror_hardwares: [amdexperimental] | |||
There was a problem hiding this comment.
While disabling failing tests on amdproduction is a practical step to unblock the CI, it's important to track this change to ensure it's not permanent. Could you add an inline comment with a brief explanation and a link to a tracking issue (if available)? This will help prevent the disabled test suite from being forgotten and provide context for future maintainers.
mirror_hardwares: [amdexperimental] # Temporarily disabled on amdproduction due to failing tests. See issue #<ISSUE_NUMBER>.
| @@ -420,7 +420,7 @@ steps: | |||
| - pytest -v -s kernels/mamba | |||
|
|
|||
| - label: Tensorizer Test # 11min | |||
| mirror_hardwares: [amdexperimental, amdproduction] | |||
| mirror_hardwares: [amdexperimental] | |||
There was a problem hiding this comment.
While disabling failing tests on amdproduction is a practical step to unblock the CI, it's important to track this change to ensure it's not permanent. Could you add an inline comment with a brief explanation and a link to a tracking issue (if available)? This will help prevent the disabled test suite from being forgotten and provide context for future maintainers.
mirror_hardwares: [amdexperimental] # Temporarily disabled on amdproduction due to failing tests. See issue #<ISSUE_NUMBER>.
| @@ -512,7 +512,7 @@ steps: | |||
| ##### models test ##### | |||
|
|
|||
| - label: Basic Models Test # 24min | |||
| mirror_hardwares: [amdexperimental, amdproduction] | |||
| mirror_hardwares: [amdexperimental] | |||
There was a problem hiding this comment.
While disabling failing tests on amdproduction is a practical step to unblock the CI, it's important to track this change to ensure it's not permanent. Could you add an inline comment with a brief explanation and a link to a tracking issue (if available)? This will help prevent the disabled test suite from being forgotten and provide context for future maintainers.
mirror_hardwares: [amdexperimental] # Temporarily disabled on amdproduction due to failing tests. See issue #<ISSUE_NUMBER>.
| @@ -601,7 +601,7 @@ steps: | |||
| - pytest -v -s models/multimodal/generation/test_common.py -m 'split(group=0) and not core_model' | |||
|
|
|||
| - label: Multi-Modal Models Test (Extended) 3 | |||
| mirror_hardwares: [amdexperimental, amdproduction] | |||
| mirror_hardwares: [amdexperimental] | |||
There was a problem hiding this comment.
While disabling failing tests on amdproduction is a practical step to unblock the CI, it's important to track this change to ensure it's not permanent. Could you add an inline comment with a brief explanation and a link to a tracking issue (if available)? This will help prevent the disabled test suite from being forgotten and provide context for future maintainers.
mirror_hardwares: [amdexperimental] # Temporarily disabled on amdproduction due to failing tests. See issue #<ISSUE_NUMBER>.
…ect#20390) Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
…ect#20390) Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Update test-pipeline.yaml
Signed-off-by: Alexei V. Ivanov alexei.ivanov@amd.com