[Misc] add handler HF_TOKEN is emptry string #20369
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @lengrongfu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the handling of the HuggingFace token (HF_TOKEN) within the vllm project. By introducing a dedicated helper function, it centralizes the logic for retrieving this token and ensures that empty or whitespace-only token values are correctly interpreted as None, mirroring the behavior of the huggingface_hub library. This change improves consistency and robustness when interacting with HuggingFace resources.
Highlights
- New Helper Function: Introduced a new private helper function,
_get_hf_token(), invllm/transformers_utils/config.py. This function standardizes the retrieval of theHF_TOKENenvironment variable. - Robust HF_TOKEN Handling: The new
_get_hf_token()function ensures that if theHF_TOKENenvironment variable is not set, is an empty string, or contains only whitespace, it is consistently treated asNone. This aligns with the behavior of thehuggingface_hublibrary to prevent authentication issues. - Centralized Token Access: Replaced direct calls to
os.getenv('HF_TOKEN', None)with the new_get_hf_token()helper across multiple functions withinvllm/transformers_utils/config.py. This includesfile_or_path_exists,get_config(multiple instances),get_sentence_transformer_tokenizer_config, andtry_get_safetensors_metadata.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Code Review
This pull request introduces a new helper function _get_hf_token to retrieve the HuggingFace token from the environment variables, ensuring that empty or whitespace-only tokens are treated as None. This change improves code maintainability by centralizing the token retrieval logic.
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
88c6f27 to
0e44588
Compare
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Test Plan
Test Result
(Optional) Documentation Update