Skip to content

Spam folks if config.py changes #20131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2025
Merged

Spam folks if config.py changes #20131

merged 3 commits into from
Jun 26, 2025

Conversation

tlrmchlsmth
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth commented Jun 26, 2025 •
edited by github-actions bot
Loading

Purpose

Changes to vllm/config.py can be user-facing and have large impacts - this PR adds some codeowners

@tlrmchlsmth
Spam people if config.py changes
e13472e 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
@tlrmchlsmth
country grammar
a916dd5 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @tlrmchlsmth, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a process improvement by assigning specific codeowners to the vllm/config.py file. This change aims to enhance oversight and collaboration for modifications to this user-facing and impactful configuration file, ensuring that relevant team members are automatically notified and involved in reviews.

Highlights

  • Code Ownership: Established new code ownership rules for the critical vllm/config.py file. This ensures that any modifications to this user-facing configuration file automatically notify a designated group of maintainers and contributors for review.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@mergify mergify bot added the ci/build label Jun 26, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several code owners to the vllm/config.py file in the .github/CODEOWNERS file. The change aims to ensure that modifications to the configuration file are reviewed by a wider audience due to their potential impact. I suggested adding more specific comments to explain the responsibilities of the code owners.

@tlrmchlsmth
fixup, update
4963c88 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
@vllm-bot vllm-bot merged commit 0bceac9 into main Jun 26, 2025
8 of 12 checks passed
@vllm-bot vllm-bot deleted the more_spam branch June 26, 2025 15:19
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Jun 26, 2025
@tlrmchlsmth @gmarinho2
Spam folks if config.py changes (vllm-project#20131)
2096dcb 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 30, 2025
@tlrmchlsmth
Spam folks if config.py changes (vllm-project#20131)
ff29ede 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
@tlrmchlsmth
Spam folks if config.py changes (vllm-project#20131)
214d05a 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Signed-off-by: Will Eaton <weaton@redhat.com>
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
@tlrmchlsmth
Spam folks if config.py changes (vllm-project#20131)
1f4cb51 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
wwl2755-google pushed a commit to wwl2755-google/vllm that referenced this pull request Jul 1, 2025
@tlrmchlsmth @wwl2755-google
Spam folks if config.py changes (vllm-project#20131)
1b5f074 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
@tlrmchlsmth @avigny
Spam folks if config.py changes (vllm-project#20131)
814f759 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
@tlrmchlsmth @googlercolin
Spam folks if config.py changes (vllm-project#20131)
643fc9b 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ci/build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tlrmchlsmth @DarkLight1337 @vllm-bot