Skip to content

[Easy] Remove submodule added in #19463 #20039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

[Easy] Remove submodule added in #19463 #20039

merged 1 commit into from
Jun 24, 2025

Conversation

b8zhong
Copy link
Contributor

@b8zhong b8zhong commented Jun 24, 2025

I think it was added in #19463? I'm guessing its vllm FA. Just happened to see it randomly. I've definitely done this before too 😅

@b8zhong
remove submodule
4b5ef6a 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@LucasWilkinson LucasWilkinson enabled auto-merge (squash) June 24, 2025 20:14
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 24, 2025
@WoosukKwon WoosukKwon disabled auto-merge June 24, 2025 20:22
@WoosukKwon WoosukKwon merged commit ead3698 into vllm-project:main Jun 24, 2025
12 of 20 checks passed
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Jun 26, 2025
@b8zhong @gmarinho2
[Easy] Remove submodule added in vllm-project#19463 (vllm-project#20039)
d469ef5 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 30, 2025
@b8zhong
[Easy] Remove submodule added in vllm-project#19463 (vllm-project#20039)
51b146e 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
@b8zhong
[Easy] Remove submodule added in vllm-project#19463 (vllm-project#20039)
99dd567 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Signed-off-by: Will Eaton <weaton@redhat.com>
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
@b8zhong
[Easy] Remove submodule added in vllm-project#19463 (vllm-project#20039)
d00a635 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
wwl2755-google pushed a commit to wwl2755-google/vllm that referenced this pull request Jul 1, 2025
@b8zhong @wwl2755-google
[Easy] Remove submodule added in vllm-project#19463 (vllm-project#20039)
4003a14 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
@b8zhong b8zhong deleted the fix/rando branch July 6, 2025 12:55
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
@b8zhong @avigny
[Easy] Remove submodule added in vllm-project#19463 (vllm-project#20039)
2aa9458 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
@b8zhong @googlercolin
[Easy] Remove submodule added in vllm-project#19463 (vllm-project#20039)
f7e9cff 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasWilkinson LucasWilkinson LucasWilkinson approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b8zhong @LucasWilkinson @WoosukKwon