[Fix][V1] Remove --scheduling-policy oracle #20010
Conversation
Signed-off-by: amit <amit.man@gmail.com>
There was a problem hiding this comment.
Summary of Changes
Hello @amitm02, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a lingering issue where the --scheduling-policy flag would still trigger an unsupported feature exception when used with the V1 engine, despite a previous attempt to disable this behavior. The change ensures that the V1 engine now correctly bypasses this specific compatibility check.
Highlights
- Bug Fix: Correctly disables the exception for the
--scheduling-policyflag when running with the V1 engine, addressing an oversight from a previous pull request. - Code Removal: Removes a specific conditional check within the
_is_v1_supported_oraclemethod that was erroneously raising an exception ifself.scheduling_policydiffered fromSchedulerConfig.policy.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Code Review
The code changes remove a check for the --scheduling-policy flag when running V1. Ensure that this removal does not introduce any regressions or unintended behavior, and that the functionality related to scheduling policy is still correctly handled or no longer relevant in the V1 engine.
…ity in V1 Signed-off-by: amit <amit.man@gmail.com>
Signed-off-by: amit <amit.man@gmail.com>
Signed-off-by: amit <amit.man@gmail.com>
Signed-off-by: amit <amit.man@gmail.com> Signed-off-by: Will Eaton <weaton@redhat.com>
Signed-off-by: amit <amit.man@gmail.com>
Signed-off-by: amit <amit.man@gmail.com>
Signed-off-by: amit <amit.man@gmail.com> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Signed-off-by: amit <amit.man@gmail.com>
The previously merged PR #19057 failed to disable the exception when --scheduling-policy was defined while running V1.