[Docs] fix minimax tool_calling docs error #20667
Conversation
Signed-off-by: qingjun <qingjun@minimaxi.com>
There was a problem hiding this comment.
Summary of Changes
Hello @qscqesze, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor but important documentation inaccuracy by correcting file paths related to MiniMax tool-calling templates. The change ensures that users referencing the documentation will be directed to the correct template files, improving the accuracy and usability of the provided examples.
Highlights
- Documentation Correction: Updated file paths for MiniMax tool-calling chat templates in
docs/features/tool_calling.mdto include the_m1suffix, ensuring correct references for both model examples and the associated command-line flag.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a documentation issue by updating references to the minimax tool-calling chat template. The file path was missing the _m1 suffix, and this change corrects it in all relevant places in docs/features/tool_calling.md. The change is accurate, self-contained, and aligns with the provided example file. The PR is good to merge.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com> Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
Signed-off-by: qingjun <qingjun@minimaxi.com>
This PR fixes a documentation issue where the "_m1" suffix was missing in several references.
The correct URL：https://github.com/vllm-project/vllm/blob/main/examples/tool_chat_template_minimax_m1.jinja