[Misc] Update model-specific PR tagging #19949
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Summary of Changes
Hello @ywang96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to improve the accuracy of model-specific automatic labeling for Llama and Qwen models within our Mergify configuration. The changes ensure that pull requests are more appropriately categorized, preventing mislabeling and streamlining the review process for model-specific contributions.
Highlights
- Llama PR Labeling Enhancement: I've updated the Mergify configuration to automatically apply the
model/llamalabel to pull requests whose titles contain the term 'llama' (case-insensitive). This adds another condition for automatic labeling beyond just file path matching. - Qwen PR Labeling Refinement: I've refined the Mergify rule for Qwen-related pull requests. Previously, PRs were labeled
model/qwenif 'Qwen' appeared in the PR body, which could be overly broad. I've removed this condition, so now the label will only be applied if 'Qwen' is in the PR title or if specific Qwen-related files are modified, making the labeling more precise.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the automatic PR tagging rules for Llama and Qwen models. The removal of body-based matching for Qwen is a good change to prevent overly broad tagging. The addition of title-based matching for Llama improves consistency.
I've suggested a small refinement to the new Llama title-matching regex to make it more precise by using word boundaries. For consistency, you might consider applying a similar improvement to the existing Qwen title-matching rule as well.
| @@ -45,6 +45,7 @@ pull_request_rules: | |||
| - files~=^vllm/entrypoints/openai/tool_parsers/llama.*\.py | |||
| - files~=^vllm/model_executor/models/.*llama.*\.py | |||
| - files~=^vllm/transformers_utils/configs/.*llama.*\.py | |||
| - title~=(?i)llama | |||
There was a problem hiding this comment.
The current regex (?i)llama is a bit broad and could lead to false positives by matching words that contain "llama" as a substring (e.g., "llamas").
To make the matching more precise, I suggest using word boundaries (\b). This will ensure that only the whole word "llama" is matched, case-insensitively.
- title~=(?i)\bllama\b
Signed-off-by: Roger Wang <hey@rogerw.me> Signed-off-by: juncheoll <th6re8e@naver.com>
Signed-off-by: Roger Wang <hey@rogerw.me> Signed-off-by: fhl <2410591650@qq.com>
Signed-off-by: Roger Wang <hey@rogerw.me>
Signed-off-by: Roger Wang <hey@rogerw.me>
Signed-off-by: Roger Wang <hey@rogerw.me> Signed-off-by: Will Eaton <weaton@redhat.com>
Signed-off-by: Roger Wang <hey@rogerw.me>
Signed-off-by: Roger Wang <hey@rogerw.me>
Signed-off-by: Roger Wang <hey@rogerw.me> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Signed-off-by: Roger Wang <hey@rogerw.me>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Update tagging regex for Llama and Qwen. The current regex for Qwen might be too aggressive since a PR mentioning "Qwen" in the description will trigger the labeling, which's not really the intention. See #19948 as an example.
Test Plan
Test Result
(Optional) Documentation Update