Skip to content

Fix some typo #19475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2025
Merged

Fix some typo #19475

merged 3 commits into from
Jun 11, 2025

Conversation

Ximingwang-09
Copy link
Contributor

@Ximingwang-09 Ximingwang-09 commented Jun 11, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

vllm/model_executor/layers/rejection_sampler.py

@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

DarkLight1337
DarkLight1337 reviewed Jun 11, 2025
View reviewed changes
DarkLight1337
DarkLight1337 reviewed Jun 11, 2025
View reviewed changes
ximing.wxm added 3 commits June 11, 2025 15:23
fix typo
c7e3c0e 
Signed-off-by: ximing.wxm <ximing.wxm@antgroup.com>
fix
708c5d4 
Signed-off-by: ximing.wxm <ximing.wxm@antgroup.com>
fix
edb37a7 
Signed-off-by: ximing.wxm <ximing.wxm@antgroup.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) June 11, 2025 07:25
@DarkLight1337
Copy link
Member

Thanks for fixing!

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 11, 2025
@DarkLight1337 DarkLight1337 merged commit 3c8694e into vllm-project:main Jun 11, 2025
69 of 70 checks passed
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@Ximingwang-09 @minpeter
Fix some typo (vllm-project#19475)
6980cc7 
Signed-off-by: ximing.wxm <ximing.wxm@antgroup.com>
Co-authored-by: ximing.wxm <ximing.wxm@antgroup.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 30, 2025
@Ximingwang-09
Fix some typo (vllm-project#19475)
2a85003 
Signed-off-by: ximing.wxm <ximing.wxm@antgroup.com>
Co-authored-by: ximing.wxm <ximing.wxm@antgroup.com>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
@Ximingwang-09 @avigny
Fix some typo (vllm-project#19475)
d3d4342 
Signed-off-by: ximing.wxm <ximing.wxm@antgroup.com>
Co-authored-by: ximing.wxm <ximing.wxm@antgroup.com>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
@Ximingwang-09 @googlercolin
Fix some typo (vllm-project#19475)
aee4be0 
Signed-off-by: ximing.wxm <ximing.wxm@antgroup.com>
Co-authored-by: ximing.wxm <ximing.wxm@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ximingwang-09 @DarkLight1337