Skip to content

Support non-string values in JSON keys from CLI #19471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

Support non-string values in JSON keys from CLI #19471

merged 1 commit into from
Jun 11, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jun 11, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

FIX #19030 (comment)

Test Plan

Updated test_config,py

Test Result

The test passes

(Optional) Documentation Update

@DarkLight1337
Support non-string values in JSON keys from CLI
71a4efd 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from hmellor June 11, 2025 06:19
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 11, 2025
@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request Jun 11, 2025
Merged
@DarkLight1337 DarkLight1337 requested a review from mgoin June 11, 2025 06:19
DarkLight1337
DarkLight1337 commented Jun 11, 2025
View reviewed changes
tests/test_config.py
@@ -13,32 +13,32 @@
from vllm.platforms import current_platform


class TestConfig1:
class _TestConfig1:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added underscore to the names to silence the pytest warnings, since normally classes beginning with Test are supposed to be test suites.

DarkLight1337
DarkLight1337 commented Jun 11, 2025
View reviewed changes
vllm/utils.py
@@ -1466,7 +1466,7 @@ def repl(match: re.Match) -> str:
pattern = re.compile(r"(?<=--)[^\.]*")

# Convert underscores to dashes and vice versa in argument names
processed_args = []
processed_args = list[str]()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the type annotations

DarkLight1337
DarkLight1337 commented Jun 11, 2025
View reviewed changes
vllm/utils.py
Comment on lines +1522 to +1525
try:
value = json.loads(value_str)
except json.decoder.JSONDecodeError:
value = value_str
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change in this PR which enables non-string values to be parsed correctly

houseroad
houseroad approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) June 11, 2025 06:53
@DarkLight1337 DarkLight1337 merged commit a2142f0 into vllm-project:main Jun 11, 2025
67 checks passed
@DarkLight1337 DarkLight1337 deleted the json-non-string branch June 11, 2025 09:34
@rdodev
Copy link

rdodev commented Jun 11, 2025

@dark I'll test this later today and will let you know.

minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@DarkLight1337 @minpeter
Support non-string values in JSON keys from CLI (vllm-project#19471)
51c8a30 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: minpeter <kali2005611@gmail.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 30, 2025
@DarkLight1337
Support non-string values in JSON keys from CLI (vllm-project#19471)
6c40f8b 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
@DarkLight1337 @avigny
Support non-string values in JSON keys from CLI (vllm-project#19471)
bfebe7e 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseroad houseroad houseroad approved these changes

@hmellor hmellor Awaiting requested review from hmellor

@mgoin mgoin Awaiting requested review from mgoin

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @rdodev @houseroad