Skip to content

[Bugfix] Update the example code, make it work with the latest lmcache #19453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2025
Merged

[Bugfix] Update the example code, make it work with the latest lmcache #19453

merged 3 commits into from
Jun 11, 2025

Conversation

runzhen
Copy link
Contributor

@runzhen runzhen commented Jun 11, 2025 •
edited by github-actions bot
Loading

The latest lmcache code don't have lmcache.experimental any more, instead, the new path is lmcache.v1 .
So when run the example, it will have the No module named 'lmcache.experimental error, this PR fixes this issue.

@runzhen
[Bugfix] Update the example code, make it work with the latest lmcache
403454e 
Signed-off-by: Runzhen Wang <wangrunzhen@gmail.com>
@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Jun 11, 2025
DarkLight1337
DarkLight1337 reviewed Jun 11, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @reidliu41 can you help review this?

@reidliu41
Copy link
Contributor

yeah, they updated two weeks ago LMCache/LMCache#704,
and I just tested the change that worked.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) June 11, 2025 08:22
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 11, 2025
@DarkLight1337 DarkLight1337 merged commit 943ffa5 into vllm-project:main Jun 11, 2025
53 of 55 checks passed
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@runzhen @minpeter
[Bugfix] Update the example code, make it work with the latest lmcache (
e525523 
vllm-project#19453)

Signed-off-by: Runzhen Wang <wangrunzhen@gmail.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 30, 2025
@runzhen
[Bugfix] Update the example code, make it work with the latest lmcache (
8c1bb9c 
vllm-project#19453)

Signed-off-by: Runzhen Wang <wangrunzhen@gmail.com>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
@runzhen @avigny
[Bugfix] Update the example code, make it work with the latest lmcache (
7511253 
vllm-project#19453)

Signed-off-by: Runzhen Wang <wangrunzhen@gmail.com>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
@runzhen @googlercolin
[Bugfix] Update the example code, make it work with the latest lmcache (
5babac7 
vllm-project#19453)

Signed-off-by: Runzhen Wang <wangrunzhen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

+1 more reviewer

@reidliu41 reidliu41 reidliu41 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runzhen @reidliu41 @DarkLight1337