[ROCm][V1] Adding ROCm to the list of plaforms using V1 by default #19440
Conversation
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Summary of Changes
Hello @gshtras, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the V1 support logic to treat ROCm platforms the same as CUDA platforms, enabling V1 by default for ROCm by adjusting a platform detection check.
Highlights
- Enable V1 for ROCm by default: Modified the platform check in
_is_v1_supported_oracleto useis_cuda_alike()instead ofis_cuda(). This change includes ROCm platforms (which are covered byis_cuda_alike()) in the set of hardware where V1 is enabled by default, aligning ROCm's default behavior with CUDA's.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request successfully updates the _is_v1_supported_oracle function to include ROCm platforms in the check for V1 support by utilizing the is_cuda_alike() method. This aligns with the stated objective of adding ROCm to the list of platforms using V1 by default. The change is minimal and correctly implements the intended logic. No critical issues were found in the code changes.
Yay! |
…llm-project#19440) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: minpeter <kali2005611@gmail.com>
…llm-project#19440) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
…llm-project#19440) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
…llm-project#19440) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Adding ROCm to the list of platforms fully supporting V1 (through cuda_alike which includes both rocm and cuda)