[ROCm] Add rules to automatically label ROCm related PRs #19405
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @houseroad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces automation via Mergify to automatically apply the rocm label to pull requests that are likely related to AMD GPUs. This is intended to streamline the review and triage process by making ROCm-specific changes easily identifiable based on the files modified or keywords in the title.
Highlights
- New Mergify Rule: Added a new rule to
.github/mergify.ymlto automatically label pull requests. - ROCm Labeling: The new rule specifically targets pull requests related to ROCm (AMD GPU) by checking file paths and title keywords.
- Conditions: The rule applies the
rocmlabel if changes are detected in specific ROCm-related directories/files (e.g.,csrc/rocm/,requirements/rocm.*.txt,vllm/attention/backends/rocm.*.py, etc.) or if the title contains 'AMD' or 'ROCm' (case-insensitive).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new Mergify rule to automatically label ROCm-related pull requests. The rule conditions include a comprehensive list of file paths and patterns, as well as title keywords, to identify ROCm changes. The overall approach is sound and should help in triaging ROCm PRs.
My main feedback concerns one of the Dockerfile paths specified in the conditions, which might be a typo or could be made more comprehensive by including the primary ROCm Dockerfile. Please see the specific comment for details.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Lu Fang <lufang@fb.com>
13adfbd to
704c8f2
Compare
…t#19405) Signed-off-by: Lu Fang <lufang@fb.com> Signed-off-by: minpeter <kali2005611@gmail.com>
…t#19405) Signed-off-by: Lu Fang <lufang@fb.com>
…t#19405) Signed-off-by: Lu Fang <lufang@fb.com> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
…t#19405) Signed-off-by: Lu Fang <lufang@fb.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Automatically label ROCm (AMD GPU) related PRs, so it will ease the review and related triage.
Test Plan
Tested in the simulator.
Test Result
The PRs are tagged appropriately.
Such as #19404 is not tagged.
#18596 is tagged correctly.
(Optional) Documentation Update
N/A