Skip to content

[Bugfix] Avoid transferring cached multi-modal items from P0 to P1 #16273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2025
Merged

[Bugfix] Avoid transferring cached multi-modal items from P0 to P1 #16273

merged 5 commits into from
Apr 9, 2025

Conversation

DarkLight1337
Copy link
Member

Fix a regression introduced by #14864 which caused multi-modal items to be sent from P0 to P1 even when they exist in the cache.

@DarkLight1337
[Bugfix] Avoid transfering cached multi-modal items from P0 to P1
b3dbf5c 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request Apr 8, 2025
Closed
1 task
@mergify mergify bot added the v1 label Apr 8, 2025
This was referenced Apr 8, 2025
Closed
Closed
Closed
@DarkLight1337 DarkLight1337 changed the title [Bugfix] Avoid transfering cached multi-modal items from P0 to P1 [Bugfix] Avoid transferring cached multi-modal items from P0 to P1 Apr 8, 2025
@mergify Mergify
Copy link

mergify bot commented Apr 8, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @DarkLight1337.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 8, 2025
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 8, 2025
@DarkLight1337
Merge branch 'main' into fix-mm-data-transfer
c54efe9 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@mergify mergify bot removed the needs-rebase label Apr 8, 2025
@DarkLight1337
Merge branch 'main' into fix-mm-data-transfer
48253d3
@DarkLight1337
Revert variable name change
f920e47 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Improve naming
fec139a 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@ywang96 ywang96 merged commit e484e02 into vllm-project:main Apr 9, 2025
41 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-mm-data-transfer branch April 9, 2025 07:52
zRzRzRzRzRzRzR pushed a commit to zRzRzRzRzRzRzR/vllm that referenced this pull request Apr 9, 2025
@DarkLight1337 @zRzRzRzRzRzRzR
[Bugfix] Avoid transferring cached multi-modal items from P0 to P1 (v…
b86e411 
…llm-project#16273)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
@DarkLight1337 DarkLight1337 mentioned this pull request Apr 10, 2025
Merged
5 tasks
@courage17340 courage17340 mentioned this pull request Apr 10, 2025
Merged
@p88h p88h mentioned this pull request Apr 10, 2025
Merged
liuzijing2014
liuzijing2014 reviewed Apr 11, 2025
View reviewed changes
This was referenced Apr 12, 2025
Open
Merged
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@DarkLight1337 @yangw-dev
[Bugfix] Avoid transferring cached multi-modal items from P0 to P1 (v…
63762e5 
…llm-project#16273)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @dbyoung18
[Bugfix] Avoid transferring cached multi-modal items from P0 to P1 (v…
4b89f1d 
…llm-project#16273)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Bugfix] Avoid transferring cached multi-modal items from P0 to P1 (v…
29a88ff 
…llm-project#16273)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Bugfix] Avoid transferring cached multi-modal items from P0 to P1 (v…
faaaf56 
…llm-project#16273)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywang96 ywang96 ywang96 approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

+2 more reviewers

@shuttie shuttie shuttie left review comments

@liuzijing2014 liuzijing2014 liuzijing2014 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DarkLight1337 @shuttie @liuzijing2014 @ywang96