Skip to content

Improve configs - MultiModalConfig + PoolerConfig + DecodingConfig #16789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 18, 2025
Merged

Improve configs - MultiModalConfig + PoolerConfig + DecodingConfig #16789

merged 5 commits into from
Apr 18, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Apr 17, 2025

Follows #16332, #16422, #16533, #16603

Notable changes:

  • --limit-mm-per-prompt moves away from the custom nullable_kvs type in preference to JSON strings (which are used for all other mapping inputs)
  • The nullable_kvs will still work as a fallback with a warning during the transition period

hmellor added 3 commits April 17, 2025 16:11
@hmellor
Improve DecodingConfig
2c61c7f 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Improve PoolerConfig
b07005b 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Improve MultiModalConfig
256eb48 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194) labels Apr 17, 2025
DarkLight1337
DarkLight1337 reviewed Apr 17, 2025
View reviewed changes
DarkLight1337
DarkLight1337 reviewed Apr 17, 2025
View reviewed changes
@hmellor
Review comments
8f33dc9 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
DarkLight1337
DarkLight1337 reviewed Apr 17, 2025
View reviewed changes
tests/models/decoder_only/audio_language/test_ultravox.py Outdated
args = [
"--dtype=bfloat16", "--max-model-len=4096", "--enforce-eager",
f'--limit-mm-per-prompt={{"audio":{len(audio_assets)}}}',
"--trust-remote-code"
f"--limit-mm-per-prompt='{limit_mm_per_prompt}'", "--trust-remote-code"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate the arguments

DarkLight1337
DarkLight1337 reviewed Apr 17, 2025
View reviewed changes
DarkLight1337
DarkLight1337 reviewed Apr 17, 2025
View reviewed changes
@hmellor
Review comments
206d69a 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 17, 2025 16:23
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 17, 2025
@vllm-bot vllm-bot merged commit e78587a into vllm-project:main Apr 18, 2025
47 of 52 checks passed
@hmellor hmellor mentioned this pull request Apr 18, 2025
Merged
@hmellor hmellor changed the title Improve-mm-and-pooler-and-decoding-configs Improve configs - MultiModalConfig + PoolerConfig + DecodingConfig Apr 18, 2025
@hmellor hmellor mentioned this pull request Apr 18, 2025
Merged
@hmellor hmellor deleted the improve-mm-and-pooler-and-decoding-configs branch April 18, 2025 10:27
@tjohnson31415 tjohnson31415 mentioned this pull request Apr 18, 2025
Merged
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@hmellor @yangw-dev
Improve-mm-and-pooler-and-decoding-configs (vllm-project#16789)
2062e57 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
This was referenced Apr 22, 2025
Merged
Merged
@tjohnson31415 tjohnson31415 mentioned this pull request Apr 22, 2025
Closed
1 task
@hmellor hmellor mentioned this pull request Apr 24, 2025
Merged
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@hmellor @dbyoung18
Improve-mm-and-pooler-and-decoding-configs (vllm-project#16789)
5794918 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@hmellor @lk-chen
Improve-mm-and-pooler-and-decoding-configs (vllm-project#16789)
ee0db73 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@hmellor @adobrzyn
Improve-mm-and-pooler-and-decoding-configs (vllm-project#16789)
02b18f6 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
@hmellor hmellor mentioned this pull request Apr 30, 2025
Merged
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Improve-mm-and-pooler-and-decoding-configs (vllm-project#16789)
e9c6cbc 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmellor @DarkLight1337 @vllm-bot