Skip to content

fix(coverage): prevent encoding filenames of uncovered files #8239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

fix(coverage): prevent encoding filenames of uncovered files #8239

merged 1 commit into from
Jul 1, 2025
+94 −4

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jun 30, 2025 •
edited
Loading

Description

Node's documentation for pathToFileURL describes this case: https://nodejs.org/api/url.html#urlpathtofileurlpath-options

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify Netlify
Copy link

netlify bot commented Jun 30, 2025

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fcd9a50
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6862dc9c2d5d7300088752bd
😎 Deploy Preview https://deploy-preview-8239--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@AriPerkkio AriPerkkio force-pushed the fix/coverage-filename-url-confusion branch from fcd9a50 to 546889e Compare July 1, 2025 06:32
@AriPerkkio AriPerkkio marked this pull request as ready for review July 1, 2025 06:32
@AriPerkkio AriPerkkio marked this pull request as draft July 1, 2025 06:41
@AriPerkkio AriPerkkio force-pushed the fix/coverage-filename-url-confusion branch from 2cd02ba to 2c1c772 Compare July 1, 2025 06:52
@AriPerkkio AriPerkkio force-pushed the fix/coverage-filename-url-confusion branch from 2c1c772 to 13ffa9a Compare July 1, 2025 07:08
@AriPerkkio AriPerkkio marked this pull request as ready for review July 1, 2025 07:27
@sheremet-va sheremet-va merged commit 8a99880 into vitest-dev:main Jul 1, 2025
25 of 26 checks passed
@AriPerkkio AriPerkkio deleted the fix/coverage-filename-url-confusion branch July 1, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

experimentalAstAwareRemapping fails for uncovered files with non-standard symbols in their names
2 participants
@AriPerkkio @sheremet-va