fix(vitest): override config.include
option with config.browser.instances[].include
option if it is specified
#8260
+81
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close: #7914
Hi Team 👋
As described in #7914 (comment), I understand that #7914 happens because
mergeConfig
merges array in config object instead of overriding it.As mentioned in docs, vitest config root's
include
option has['**/*.{test,spec}.?(c|m)[jt]s?(x)']
as default value, and config which is calculated per browser instance configuration will be like below:and so,
'**/*.{test,spec}.?(c|m)[jt]s?(x)'
pattern in firefox's config will match test files which should be ignored byconfig.browsers.instances[firefox].include
.I thought vitest user expect include config in deeper will be prioritized than the root that, so I fixed this issue by ignoreing project root's include value if
config.browser.instances[].include
is specified.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.