Skip to content

fix: use correct path for optimisation of strip-literal #8139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

fix: use correct path for optimisation of strip-literal #8139

merged 1 commit into from
Jun 10, 2025

Conversation

mrginglymus
Copy link
Contributor

@mrginglymus mrginglymus commented Jun 10, 2025 •
edited
Loading

Description

#8127 added vitest > strip-literal to optimisedeps.include, but strip-literal is actually a dependency of @vitest/runner

On package managers with strict module resolution, this dependency chain doesn't exist, so is skipped, and js-tokens isn't transpiled causing many explosions.

This PR adds the correct path, to reduce explosions.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify Netlify
Copy link

netlify bot commented Jun 10, 2025

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 043cf38
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6847f880f9244300081f2877
😎 Deploy Preview https://deploy-preview-8139--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

AriPerkkio
AriPerkkio approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've lost count how many times I've misconfigured optimizeDeps so far. Really, really don't like its API.

Thanks for the fix!

@AriPerkkio AriPerkkio requested a review from sheremet-va June 10, 2025 10:14
@sheremet-va sheremet-va merged commit 44940d9 into vitest-dev:main Jun 10, 2025
12 of 14 checks passed
@mrginglymus mrginglymus deleted the fix-strip-opt branch June 10, 2025 10:38
@renovate renovate bot mentioned this pull request Jul 4, 2025
Open
@khankhan389 khankhan389 mentioned this pull request Jul 22, 2025
Open
@renovate renovate bot mentioned this pull request Jul 25, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AriPerkkio AriPerkkio AriPerkkio approved these changes

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vitest 3.2.3 + browser incompatible with yarn pnp
3 participants
@mrginglymus @AriPerkkio @sheremet-va