Skip to content

fix: support snapshot with no object key sorting #8136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jun 10, 2025

Description

This changes snapshotFormat.compareKeys option to handle null value. Note that internally there's also a same option for diff.compareKeys, but it's likely this is not meaningful to support since toEqual assertion doesn't take into account the key order.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa hi-ogawa marked this pull request as ready for review June 10, 2025 00:46
Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 1355195
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6848538352698d00080bc002
😎 Deploy Preview https://deploy-preview-8136--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va merged commit e85e396 into vitest-dev:main Jul 14, 2025
11 of 14 checks passed
@hi-ogawa hi-ogawa deleted the fix-snapshotFormat-no-sort-keys branch July 14, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants