Skip to content

fix(runner): preserve handler wrapping on extend #8153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

fix(runner): preserve handler wrapping on extend #8153

merged 2 commits into from
Jun 17, 2025

Conversation

pengooseDev
Copy link
Contributor

Description

Closes #8117

  • add regression test for extend handler wrapping
  • update createTaskCollector > taskFn.extend implementation.
    • Call the original wrapper instead of the low-level collector.test.fn.call

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@pengooseDev
test(task-collector): add regression test for extend handler wrapping
d7edb59 
Add a regression test to verify that createTaskCollector.extend() preserves the handler wrapping logic.
Uses a flag reset/assert pattern to ensure the wrapper resets state and asserts correctly.

Refs: vitest-dev#8117
@pengooseDev
fix(task-collector): preserve handler wrapping on extend
2b12456 
Change extend() implementation to:
- parse out handler and timeout via parseArguments
- call the original wrapper (originalWrapper.call) with (name, handler, timeout)

Closes: vitest-dev#8117
@netlify Netlify
Copy link

netlify bot commented Jun 12, 2025

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2b12456
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/684a6439186ba400085061ca
😎 Deploy Preview https://deploy-preview-8153--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va merged commit a92812b into vitest-dev:main Jun 17, 2025
22 of 26 checks passed
This was referenced Jun 19, 2025
Open
Open
Closed
@renovate renovate bot mentioned this pull request Jul 6, 2025
Merged
1 task
@AriPerkkio AriPerkkio mentioned this pull request Jul 8, 2025
Closed
6 tasks
@khankhan389 khankhan389 mentioned this pull request Jul 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Task Functions that call .extend have their wrapped handlers ignored
2 participants
@pengooseDev @sheremet-va