feat: support rolldown-vite #7509

sheremet-va · 2025-02-17T14:46:39Z

Description

Good thing is that Vitest works with vite-rolldown for the most part (99%)

Removed sveltekit example for now because pnpm didn't like vite override and I don't want to deal with it 👀
Issues:
- vite-rolldown doesn't expose Rollup.Program (or Rolldown.Program?)
- rolldown doesn't support using syntax - we are transpiling the code down to node18, but it still doesn't work (although we use the esbuild field 🤔 ) - the test is skipped for now
  - there is no way to change the transform plugin if experimental.enableNativePlugin is true (the default)
  - examples/lit decorators don't seem to work correctly:

target was modified to include ES2021 because useDefineForClassFields is set to false and oxc does not support transforming useDefineForClassFields=false for ES2022+ yet

✅ vite-rolldown uses '' + import.meta.url when transforming new URL to opt-out of rolldown's transform (this is an easy regexp change). Vitest also changes this transform to make the URL closer to the one that will be resolved in the browser (in node.js import.meta.url refers to a file, but we need a server URL there)
✅ does optimizeDeps.rollupOptions.resolve.alias work? Browser Mode aliases vue packages to CJS versions testing-library is CJS (and it should import the same version of test-utils), and also we want to have the ability to use string slots and string templates
✅ seems like I see this message even if I didn't specify any esbuildOptions (we always check for an empty stderr and this breaks some tests):

You've set "optimizeDeps.esbuildOptions" in your config. This is deprecated and vite already use rollup to optimize packages. Please use "optimizeDeps.rollupOptions" instead.

The value of esbuildOptions is { preserveSymlinks: false } and the environment name is client 🤔

This comes probably from here:

https://github.com/rolldown/vite/blob/1eee1f56ee90a08d82f465900caea6f2a618d358/packages/vite/src/node/config.ts#L1139

✅ styles in the UI seem to be completely broken when built with vite-rolldown

~~source maps sometimes are not correct. See test/config/unhandled-rejections.test.ts - the column should be 42 (this MIGHT BE an issue with custom Vitest plugins, but it was not a problem before):~~

  ❯ setup-unhandled-rejections.ts:2:41
       1| export function setup() {
       2|   void new Promise((_, reject) => reject(new Error('intentional unhand…
        |                                         ^ (this is incorrect position)
        |                                          ^ (it should be here where new Error starts)
       3| }

Note

Seems like we always had "Re-optimizing dependencies because vite config has changed" because of incorrect usage of cacheDir

netlify · 2025-02-17T14:49:38Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`5fcae89`
🔍 Latest deploy log	https://app.netlify.com/projects/vitest-dev/deploys/683f8ed3d5787000080bc0d2
😎 Deploy Preview	https://deploy-preview-7509--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa · 2025-02-18T01:00:28Z

Good thing is that Vitest works with vite-rolldown for the most part (99%)

Awesome progress already! 🎉

rolldown doesn't support using syntax - we are transpiling the code down to node18, but it still doesn't work (although we use the esbuild field 🤔 ) - the test is skipped for now

...

examples/lit decorators don't seem to work correctly:

These two are oxc transform issues and they are tracked in oxc-project/oxc#9168 and oxc-project/oxc#9129.

styles in the UI seem to be completely broken when built with vite-rolldown

Probably this is because of unocss plugin not working unocss/unocss#4403.

sapphi-red · 2025-02-18T01:19:44Z

Great!

does optimizeDeps.rollupOptions.resolve.alias work? Browser Mode aliases vue packages to CJS versions testing-library is CJS (and it should import the same version of test-utils), and also we want to have the ability to use string slots and string templates

I've fixed that yesterday so maybe it'll work if you upgrade rolldown-vite.
vitejs/rolldown-vite@1eee1f5

seems like I see this message even if I didn't specify any esbuildOptions (we always check for an empty stderr and this breaks some tests):

You've set "optimizeDeps.esbuildOptions" in your config. This is deprecated and vite already use rollup to optimize packages. Please use "optimizeDeps.rollupOptions" instead.

I'll take a look this one.

optimizer unexpectedly re-optimizes dependencies with a message:

~~Is it actually re-optimized? or is it just the message?~~ Ah, ok, it noticed that this message is shown by the scanner.

sapphi-red · 2025-02-18T03:18:14Z

I've fixed the things related to warnings.

I also took a look the sourcemap one. I found that the sourcemaps output by OXC are slightly different from esbuild (oxc-project/oxc#9187). But I'm not sure if that's the reason.
I extracted the result here

vitest/packages/vite-node/src/client.ts

Line 507 in 6cc408d

const code = `${codeDefinition}${transformed}\n}}`

and tried to reproduce it minimally by doing

// run.mjs
import 'source-map-support/register.js'
globalThis.__vite_ssr_exports__ = {}
await import('./run2.mjs')
globalThis.__vite_ssr_exports__.setup()

// ---------------------------
// run2.mjs
'use strict';function setup() {
	void new Promise((_, reject) => reject(new Error("intentional unhandled rejection")));
}
Object.defineProperty(__vite_ssr_exports__, "setup", { enumerable: true, configurable: true, get(){ return setup }});

//# sourceMappingSource=vite-node
//# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJtYXBwaW5ncyI6IkFBQU8sU0FBUyxRQUFRO0FBQ3RCLE1BQUssSUFBSSxRQUFRLENBQUMsR0FBRyxXQUFXLE9BQU8sSUFBSSxNQUFNLG1DQUFtQztBQUNyRiIsIm5hbWVzIjpbXSwiaWdub3JlTGlzdCI6W10sInNvdXJjZXMiOlsic2V0dXAtdW5oYW5kbGVkLXJlamVjdGlvbnMudHMiXSwic291cmNlc0NvbnRlbnQiOlsiZXhwb3J0IGZ1bmN0aW9uIHNldHVwKCkge1xuICB2b2lkIG5ldyBQcm9taXNlKChfLCByZWplY3QpID0+IHJlamVjdChuZXcgRXJyb3IoJ2ludGVudGlvbmFsIHVuaGFuZGxlZCByZWplY3Rpb24nKSkpXG59XG4iXSwiZmlsZSI6IkQ6L2RvY3VtZW50cy9HaXRIdWIvdml0ZXN0L3Rlc3QvY29uZmlnL2ZpeHR1cmVzL3VuaGFuZGxlZC1yZWplY3Rpb25zL3NldHVwLXVuaGFuZGxlZC1yZWplY3Rpb25zLnRzIn0=

But the error message showed setup-unhandled-rejections.ts:2:42.

hi-ogawa · 2025-02-18T03:28:13Z

Ah, I should've mentioned earlier. Source map for global setup is not supported due to Vitest side #7101. The current assertion setup-unhandled-rejections.ts:2:42 works because transform output miraculously matched original source.

sapphi-red · 2025-02-18T04:00:31Z

Ah, I see.

hi-ogawa · 2025-02-18T04:18:27Z

@sheremet-va How did you run this PR locally? If I added rolldown-vite overrides, some dts build is failing, for example:

$ pnpm -C packages/vite-node build
src/source-map.ts(36,37): error TS7006: Parameter 'source' implicitly has an 'any' type.

[!] (plugin dts) RollupError: [plugin dts] src/source-map.ts: Failed to compile. Check the logs above.
src/source-map.ts

(The odd thing is that I don't see type error red squiggles on vscode and I have no idea what's the issue)

sheremet-va · 2025-02-18T05:06:36Z

@sheremet-va How did you run this PR locally? If I added rolldown-vite overrides, some dts build is failing, for example:
$ pnpm -C packages/vite-node build

src/source-map.ts(36,37): error TS7006: Parameter 'source' implicitly has an 'any' type.



[!] (plugin dts) RollupError: [plugin dts] src/source-map.ts: Failed to compile. Check the logs above.

src/source-map.ts
(The odd thing is that I don't see type error red squiggles on vscode and I have no idea what's the issue)

I added link: override manually to overrides in the top level package.json

Did you build vite package?

hi-ogawa · 2025-02-18T05:23:58Z

Hmm, I was using file: and that was failing. Switched to link: and now it's working on Vitest 👍 I can continue with this, but it might come back when using released package 🤔

sheremet-va · 2025-02-18T13:41:42Z

Ah, I should've mentioned earlier. Source map for global setup is not supported due to Vitest side #7101. The current assertion setup-unhandled-rejections.ts:2:42 works because transform output miraculously matched original source.

There is another difference with source maps. I am not sure if it's correct or not, I think it is caused by a difference in boundaries. This code previously had a different column:

test.each([1, 2])('custom %s', () => {
//                ^ previously returned this column
//               ^ now returns this column
})

Raw JavaScript returns the column that Rolldown returns. We had to do column-1 to get the correct column here, now this code is gone.

sheremet-va · 2025-02-18T13:58:56Z

I've fixed that yesterday so maybe it'll work if you upgrade rolldown-vite.

I used the same version yesterday. Still doesn't work (tried again today). I also tried ^@vue/test-utils$ alias, but it still doesn't seem to work. I am testing in this repo - https://github.com/vitest-dev/vitest-browser-vue (the last test expects template to work)

sapphi-red · 2025-02-19T03:29:30Z

I've fixed that yesterday so maybe it'll work if you upgrade rolldown-vite.

I used the same version yesterday. Still doesn't work (tried again today). I also tried ^@vue/test-utils$ alias, but it still doesn't seem to work. I am testing in this repo - https://github.com/vitest-dev/vitest-browser-vue (the last test expects template to work)

I think the value needs to be a resolved path instead of a unresolved specifier here.
https://github.com/vitest-dev/vitest/pull/7509/files#diff-929cb96abb1c2e297c6711af0875db4ecdc700c54b824cc4ce7e0716657b28aeR537-R543
But given that the importer is not static, I guess it needs to be a plugin like it was in esbuild.
It's confusing that resolve.alias of rolldown works differently from vite or plugin-alias's resolve.alias. I'll make a feedback to them.

sapphi-red · 2025-02-19T03:36:19Z

Ah, no, it's not that resolve.alias working differently, it's because Vite's internal plugin runs before resolve.alias. I think the workaround for now would be to be using a plugin instead as the custom plugins runs before the internal plugin.

sheremet-va · 2025-02-19T13:39:51Z

Ah, no, it's not that resolve.alias working differently, it's because Vite's internal plugin runs before resolve.alias. I think the workaround for now would be to be using a plugin instead as the custom plugins runs before the internal plugin.

A rolldown plugin seems to work correctly.

sapphi-red · 2025-02-19T13:45:43Z

I merged vitejs/rolldown-vite#82 now, so the UI should be working now.

sheremet-va · 2025-02-19T14:09:04Z

I merged rolldown/vite#82 now, so the UI should be working now.

Can confirm it does work now:

sheremet-va · 2025-02-19T14:10:57Z

I merged rolldown/vite#82 now, so the UI should be working now.

~~Is there a way to specify rolldown-vite as a dependency in this PR so CI can run with it?~~ Ok, I see it supports pkg.pr.new

…n-support

sheremet-va · 2025-06-03T07:01:10Z

Seems like there is a small issue with Vue coverage again, could you help with that, @AriPerkkio?

AriPerkkio · 2025-06-03T09:12:07Z

Seems like there is a small issue with Vue coverage again, could you help with that, @AriPerkkio?

Looks like this is failing only on the old v8 provider. Some generated code is increasing function and branch coverages. I think it's fine to leave as is, as we are planning to remove whole old v8-to-istanbul in next major.

You can just update the snapshots from the tests.

…n-support

sheremet-va · 2025-06-03T17:11:46Z

rolldown-vite now passes all tests, I am changing the dependency back to 6.3.5 and making it work there 😄

hi-ogawa

Looks good! I did a minor cleanup of package.json.

AriPerkkio

We have couple of places where we use parseAst and parseAstAsync from Vite. Are those now using oxc-parser or the SWC parser via rollup?

sapphi-red · 2025-06-04T06:16:38Z

We have couple of places where we use parseAst and parseAstAsync from Vite. Are those now using oxc-parser or the SWC parser via rollup?

parseAst and parseAstAsync exposed from rolldown-vite uses Oxc's parser.

sheremet-va · 2025-06-04T06:40:31Z

Should we add a separate CI pipeline for rolldown-vite?

sheremet-va added 2 commits February 17, 2025 15:40

feat: support rolldown-vite

b007dbc

chore: undo versioning

b1c2886

sheremet-va added 6 commits February 17, 2025 16:22

chore: break @vue/ aliasing

c6805d5

fix: enable headless in a fixture by default

2589405

chore: fix cache dir in mocker

87aba50

test: avoid watch mode trigger for generated tests

9267876

chore: cleanup

3b86125

chore: add FIXME

67c1afd

sapphi-red mentioned this pull request Feb 18, 2025

the end position in sourcemap is incorrect oxc-project/oxc#9187

Closed

hi-ogawa mentioned this pull request Feb 19, 2025

fix: allow chunk.modules mutation on js side vitejs/rolldown-vite#82

Merged

fix: patch test-utils correctly

1da1d6b

sheremet-va added 2 commits February 19, 2025 15:15

chore: use pkg.pr.new

c31db32

Merge branch 'main' of github.com:vitest-dev/vitest into feat/rolldow…

845d8a4

…n-support

sheremet-va added 3 commits June 3, 2025 12:52

chore: update v8 coverage

43da06b

chore: undo delete

7f1d4cb

Merge branch 'main' of github.com:vitest-dev/vitest into feat/rolldow…

f61806a

…n-support

sheremet-va and others added 8 commits June 3, 2025 19:12

fix: use vite instead of rolldown-vite

5558ffe

test: check if rolldown

3fee8d9

test: update exports test

b14aedd

test: exclude esnext.test.ts only on rolldown

a8df621

chore: remove unneeded overrides

4a429dc

Merge branch 'main' into feat/rolldown-support

ccd9d5b

chore: back to vite

855ac9f

chore: pnpm dedupe

5fcae89

hi-ogawa previously approved these changes Jun 4, 2025

View reviewed changes

AriPerkkio reviewed Jun 4, 2025

View reviewed changes

sheremet-va marked this pull request as ready for review June 4, 2025 06:40

ci: add rolldown-vite pipeline

a39fb5c

sheremet-va dismissed hi-ogawa’s stale review via a39fb5c June 4, 2025 06:59

sheremet-va added 4 commits June 4, 2025 09:01

chore: fix config

4f3130e

chore: install in CI anyway

8986e04

chore: hmmmm

510ca94

chore: isntall all pw browsers

4e7456c

sheremet-va merged commit c8d6264 into vitest-dev:main Jun 4, 2025
23 of 24 checks passed

sheremet-va deleted the feat/rolldown-support branch June 4, 2025 15:53

renovate bot mentioned this pull request Jun 9, 2025

chore(deps): update all non-major dependencies unplugin/unplugin-ast#101

Open

1 task

renovate bot mentioned this pull request Jul 5, 2025

chore(deps): update all non-major dependencies jellydn/moleculer-typescript-template#853

Merged

1 task

renovate bot mentioned this pull request Jul 21, 2025

chore(deps): update all non-major dependencies sxzz/stale-dep#66

Open

1 task

Uh oh!

feat: support rolldown-vite #7509

feat: support rolldown-vite #7509

Uh oh!

Conversation

sheremet-va commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

netlify bot commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vitest-dev ready!

Uh oh!

hi-ogawa commented Feb 18, 2025

Uh oh!

sapphi-red commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Feb 18, 2025

Uh oh!

hi-ogawa commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Feb 18, 2025

Uh oh!

hi-ogawa commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sheremet-va commented Feb 18, 2025

Uh oh!

hi-ogawa commented Feb 18, 2025

Uh oh!

sheremet-va commented Feb 18, 2025

Uh oh!

sheremet-va commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Feb 19, 2025

Uh oh!

sapphi-red commented Feb 19, 2025

Uh oh!

sheremet-va commented Feb 19, 2025

Uh oh!

sapphi-red commented Feb 19, 2025

Uh oh!

sheremet-va commented Feb 19, 2025

Uh oh!

sheremet-va commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sheremet-va commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AriPerkkio commented Jun 3, 2025

Uh oh!

sheremet-va commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hi-ogawa left a comment

Choose a reason for hiding this comment

Uh oh!

AriPerkkio left a comment

Choose a reason for hiding this comment

Uh oh!

sapphi-red commented Jun 4, 2025

Uh oh!

sheremet-va commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sheremet-va commented Feb 17, 2025 •

edited

Loading

netlify bot commented Feb 17, 2025 •

edited

Loading

sapphi-red commented Feb 18, 2025 •

edited

Loading

hi-ogawa commented Feb 18, 2025 •

edited

Loading

hi-ogawa commented Feb 18, 2025 •

edited

Loading

sheremet-va commented Feb 18, 2025 •

edited

Loading

sheremet-va commented Feb 19, 2025 •

edited

Loading

sheremet-va commented Jun 3, 2025 •

edited

Loading

sheremet-va commented Jun 3, 2025 •

edited

Loading

sheremet-va commented Jun 4, 2025 •

edited

Loading