fix(mocker): fix regexpHoistable to allow whitespace before parentheses (#8231)

cszhjh · web-flow · commit a0f9ae3f0490 · 2025-07-03T14:30:28.000+02:00
diff --git a/packages/mocker/src/node/hoistMocksPlugin.ts b/packages/mocker/src/node/hoistMocksPlugin.ts
@@ -68,7 +68,7 @@ export function hoistMocksPlugin(options: HoistMocksPluginOptions = {}): Plugin
   ])
 
   const regexpHoistable = new RegExp(
-    `\\b(?:${utilsObjectNames.join('|')})\\s*\.\\s*(?:${Array.from(methods).join('|')})\\(`,
+    `\\b(?:${utilsObjectNames.join('|')})\\s*\.\\s*(?:${Array.from(methods).join('|')})\\s*\\(`,
   )
 
   return {
@@ -120,7 +120,7 @@ function getNodeTail(code: string, node: Node) {
 }
 
 const regexpHoistable
-  = /\b(?:vi|vitest)\s*\.\s*(?:mock|unmock|hoisted|doMock|doUnmock)\(/
+  = /\b(?:vi|vitest)\s*\.\s*(?:mock|unmock|hoisted|doMock|doUnmock)\s*\(/
 const hashbangRE = /^#!.*\n/
 
 export interface HoistMocksResult {
diff --git a/test/core/test/tab-effect.spec.mjs b/test/core/test/tab-effect.spec.mjs
@@ -10,7 +10,7 @@ test('Are you mocking me?', () => {
 // note there are NO indents in this file
 // except the next line
 // test pass with spaces, test fails with tab
-	vi.mock('node:path', () => {
+	vi.mock ('node:path', () => {
 return {
 join: vi.fn().mockReturnValue('goodbye world')
 }

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ export function hoistMocksPlugin(options: HoistMocksPluginOptions = {}): Plugin`
`68`	`68`	`])`
`69`	`69`
`70`	`70`	`const regexpHoistable = new RegExp(`
`71`		- `\\b(?:${utilsObjectNames.join('\|')})\\s\.\\s(?:${Array.from(methods).join('\|')})\\(`,
	`71`	+ `\\b(?:${utilsObjectNames.join('\|')})\\s\.\\s(?:${Array.from(methods).join('\|')})\\s*\\(`,
`72`	`72`	`)`
`73`	`73`
`74`	`74`	`return {`
`@@ -120,7 +120,7 @@ function getNodeTail(code: string, node: Node) {`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`const regexpHoistable`
`123`		`- = /\b(?:vi\|vitest)\s\.\s(?:mock\|unmock\|hoisted\|doMock\|doUnmock)\(/`
	`123`	`+ = /\b(?:vi\|vitest)\s\.\s(?:mock\|unmock\|hoisted\|doMock\|doUnmock)\s*\(/`
`124`	`124`	`const hashbangRE = /^#!.*\n/`
`125`	`125`
`126`	`126`	`export interface HoistMocksResult {`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ test('Are you mocking me?', () => {`
`10`	`10`	`// note there are NO indents in this file`
`11`	`11`	`// except the next line`
`12`	`12`	`// test pass with spaces, test fails with tab`
`13`		`- vi.mock('node:path', () => {`
	`13`	`+ vi.mock ('node:path', () => {`
`14`	`14`	`return {`
`15`	`15`	`join: vi.fn().mockReturnValue('goodbye world')`
`16`	`16`	`}`