-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Closed
Labels
breaking changep2-edge-caseBug, but has workaround or limited in scope (priority)Bug, but has workaround or limited in scope (priority)
Milestone
Description
Describe the bug
If you set build.manifest: true
and have a file named manifest.json
in the publicDir
then the manifest.json
file will be overwritten.
As a framework, we can set the name of build.manifest
to something else, but it's impossible to know in advance all the possible file names our users may have.
Originally reported in sveltejs/kit#5803
Reproduction
git clone git@github.com:sveltejs/kit.git
cd kit/sites/kit.svelte.dev
git reset --hard 0801e8e942534d3f6c614523f0ee4fe10b602b26
pnpm install
pnpm run dev
Visit http://localhost:5173/manifest.json in the browser and see the Vite manifest rather than the file in static/manifest.json
System Info
Vite 3.0.5
Used Package Manager
pnpm
Logs
No response
Validations
- Follow our Code of Conduct
- Read the Contributing Guidelines.
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
- Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
- The provided reproduction is a minimal reproducible example of the bug.
piotr-cz and MadLittleMods
Metadata
Metadata
Assignees
Labels
breaking changep2-edge-caseBug, but has workaround or limited in scope (priority)Bug, but has workaround or limited in scope (priority)
Type
Projects
Status
Approved