Python Bindings. Again. No, really! #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…what was causing the executable to be put in wheels - pyproject.toml: add "python-binding" to features for conditional compilation - main.rs: `cargo build` was failing for the vtracer executable; I think the previous import scheme had an implicit dependency on the library being built and called 'vtracer'. The other way to do this would have been to add an explicit dependency to the [[bin]], but making explicit imports here solves things directly
…w rather than in the workflow arguments
|
Let me try |
|
This broke the Rust library usecase fyi, the compiler doesn’t find |
|
@linkmauve can you elaborate what do you mean? If the cli binary crate can build, so should any downstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[lib]section in the Cargo.toml withcrate-type = ["cdylib"]main.rs; adding an explicit[lib]caused the build to fail otherwise.I believe PyPI publish should just work, but you'll have to try that out. The build worked for all platforms, and the wheels generated contain the correct dynamic library files.