Add support for missing TUN/TAP parameters from Linux kernel #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to test this in an existing or a new UT function? |
Signed-off-by: Ivan Tsvetkov <ivanfromearth@gmail.com>
Introduce AddQueues and RemoveQueues methods for attaching and detaching queue file descriptors to an existing TUN/TAP interface in multi-queue mode. This enables controlled testing of disabled queues and fine-grained queue management without relying on interface recreation. Signed-off-by: Ivan Tsvetkov <ivanfromearth@gmail.com>
|
Hi @aboch, Yes — the changes are now covered by both extended and new unit tests. Specifically:
That said, due to time constraints I didn't implement a native test that programmatically triggers non-zero Let me know if any adjustments are needed — happy to follow up. Best regards, |
|
The two commits are more or less independent. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks! This PR fixes TUN/TAP implementation to handle several kernel parameters we've been missing. No rocket science – just closing gaps with well-known features.
What's changed
New field in
TuntapstructDisabledQueuesto track inactive multiqueue slots (critical for live migration in VMs).Now parsing kernel flags
IFLA_TUN_PI→ setsTUNTAP_NO_PI(for "raw" packet mode)IFLA_TUN_VNET_HDR→ setsTUNTAP_VNET_HDR(QEMU/virtio needs this)IFLA_TUN_MULTI_QUEUEsupportIFLA_TUN_NUM_QUEUES/DISABLED_QUEUESWhy this is needed
VNET_HDRor multiqueue configs got silently ignored.DisabledQueuesfor VM migrationsMULTI_QUEUEmatters for anyone using DPDK/VPP for fast packet processingHow I tested
✓ 4 active + 2 disabled queues
✓
VNET_HDRflag (matching QEMU's requirements)✓ Legacy configs (verified old behavior stays intact)
Notes for review
iproute2's implementation (see here) – we're not inventing wheels.Signed-off-by: Ivan Tsvetkov ivanfromearth@gmail.com