Skip to content

Support TC "sample" filter action #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Conversation

lorenz
Copy link
Contributor

@lorenz lorenz commented Dec 23, 2024

This change adds support for packet sampling using "psample" kernel module.

I'm taking this over from Mateusz in #839 who has since left the company.

@lorenz
Copy link
Contributor Author

lorenz commented Dec 23, 2024

Test failures unrelated, CI kernel sadly doesn't have CONFIG_PSAMPLE so the psample tests are skipped there.

@wangling94
Copy link
Contributor

Test failures unrelated, CI kernel sadly doesn't have CONFIG_PSAMPLE so the psample tests are skipped there.

my mr failed in same case...

#1035

@wangling94
Copy link
Contributor

i found it was caused by rule add slow, when retrieve it will failed to found rule added.

i wait 1 sec when not found the rule, and problem solved.
#1035

This change adds support for packet sampling using "psample" kernel
module.
@lorenz
Copy link
Contributor Author

lorenz commented Feb 2, 2025

@aboch Rebased, unrelated test failure is now gone.

@aboch
Copy link
Collaborator

aboch commented Mar 26, 2025

LGTM

@aboch aboch merged commit 1f910b7 into vishvananda:main Mar 26, 2025
2 checks passed
@lorenz lorenz deleted the psample-v2 branch March 26, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants