Skip to content

tests: Improve address unit test infrastructure #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

tests: Improve address unit test infrastructure #1047

merged 1 commit into from
Apr 3, 2025

Conversation

yunginnanet
Copy link
Contributor

Summary

This pull request refactors the addr_test.go file and does not touch any non-test functionality.

Changes

  • Structural Refactoring: Transition to the addrTest struct for organizing test parameters.
  • Error Handling Improvements: Centralize and simplify error handling using helper functions within the test struct. Add canFail to make some tests optional.
  • Differentiate Tests: Add test case names to separate out the test cases during troubleshooting.
  • Misc: Minor grammar fix.

@adrianchiris
Copy link
Collaborator

@yunginnanet please squash to a single commit and we can merge this one.

@yunginnanet
tests: Improve address unit test infrastructure
c285984 
Signed-off-by: kayos@tcp.direct <kayos@tcp.direct>
@adrianchiris adrianchiris merged commit 38b1229 into vishvananda:main Apr 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunginnanet @adrianchiris