Skip to content

netkit: Add support for IFLA_NETKIT_SCRUB and IFLA_NETKIT_PEER_SCRUB #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

netkit: Add support for IFLA_NETKIT_SCRUB and IFLA_NETKIT_PEER_SCRUB #1022

merged 1 commit into from
Oct 22, 2024

Conversation

jrife
Copy link
Contributor

@jrife jrife commented Sep 27, 2024 •
edited
Loading

A recent patch series adds support for two new netkit flags, IFLA_NETKIT_SCRUB and IFLA_NETKIT_PEER_SCRUB, allowing configuration of the the packet scrubbing behavior for the primary and peer device, respectively. This PR adds support for these new flags. As a follow up, this PR will be used to implement this fix in Cilium.

@jrife jrife mentioned this pull request Sep 27, 2024
Closed
4 tasks
@jrife jrife force-pushed the jrife/netkit-scrub branch 3 times, most recently from d2687fc to 271495d Compare October 9, 2024 00:33
@jrife jrife changed the title [WIP] netkit: Add support for IFLA_NETKIT_SCRUB netkit: Add support for IFLA_NETKIT_SCRUB Oct 9, 2024
@jrife jrife mentioned this pull request Oct 9, 2024
Merged
@jrife jrife marked this pull request as ready for review October 9, 2024 00:36
@jrife
Copy link
Contributor Author

jrife commented Oct 9, 2024

cc @borkmann

@jrife jrife changed the title netkit: Add support for IFLA_NETKIT_SCRUB netkit: Add support for IFLA_NETKIT_SCRUB and IFLA_NETKIT_PEER_SCRUB Oct 9, 2024
@jrife jrife force-pushed the jrife/netkit-scrub branch from 271495d to bc6d01f Compare October 9, 2024 00:48
@borkmann
Copy link
Contributor

Hi 👋 @aboch, if you get a chance, please take a look. :)

@aboch
Copy link
Collaborator

aboch commented Oct 14, 2024 •
edited
Loading

Sure this will go in.
Am I seeing correctly that the referenced addition to Linux is not even in the latest 6.13-rc?

@borkmann
Copy link
Contributor

borkmann commented Oct 14, 2024 •
edited
Loading

Sure this will go in. Am I seeing correctly that the referenced addition to Linux is not even in the latest 6.13-rc?

This is going into 6.13, not 6.12, but I expect stable to pick this up as well, for reference (top 2 commits):
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/log/drivers/net/netkit.c

@borkmann
Copy link
Contributor

@aboch Have a chance to merge if it looks good to you? (It's blocking a few important Cilium fixes in relation to netkit). Thanks so much for your help.

@jrife
Copy link
Contributor Author

jrife commented Oct 21, 2024

Just to follow up, I'm also curious what the release cadence is? We can potentially pin go.mod to a specific commit in Cilium once this is merged, but it would be nice to be pinned to a release tag.

@aboch aboch merged commit 976bd8d into vishvananda:main Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@tklauser tklauser tklauser approved these changes

@borkmann borkmann borkmann approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrife @borkmann @aboch @tklauser