-
Notifications
You must be signed in to change notification settings - Fork 788
gofumpt code #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gofumpt code #1009
Conversation
great initiative, This should ideally come with a github workflow which will ensure the project remains gofumpted. |
Yes, it would be good to set up a linter in this repo; I see #859 gave this a try, but was closed. I just ran At least this PR should set a baseline for formatting, and we can do some periodic updates to fix regressions in that area (until a linter is in place). I rebased this PR, and should be ready for review again. 🙏 |
LGTM |
☝️ short update on that effort; I also opened a PR to fix most (not all) linting issues with the default golangci-lint settings; #1048. There are still some linting issues to address after that one that may need some eyes (either fix or suppress), after which I can add a golangci-lint action to this repository. |
701f927
to
fe4839d
Compare
@aboch PTAL 🙏 (this one helps a lot with people having their editor configured to |
@aboch PTAL 🙏 |
Rebased; @aboch @vishvananda PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please rebase this one and we can merge.
Rebased 👍 |
@thaJeztah sorry, can you rebase again :) |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sure, no problem; done 👍 |
No description provided.