Skip to content

Conversation

chent1996
Copy link
Contributor

this PR add support to manage a netkit device in Golang

authored-by: tangchen tangchen.1@bytedance.com

netkit device is merged to Linux upstream:
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=22360fad5889cbefe1eca695b0cc0273ab280b56

this PR add support to manage a netkit device in Golang

authored-by: tangchen <tangchen.1@bytedance.com>
@chent1996
Copy link
Contributor Author

Copy link
Contributor

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for working on this!

@borkmann
Copy link
Contributor

Cc @aboch 👋

Copy link
Contributor

@NikAleksandrov NikAleksandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@hemanthmalla hemanthmalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chent1996 Looks great. I was about to make the same PR, but your work looks more exhaustive. Thank you.

@aboch
Copy link
Collaborator

aboch commented Nov 27, 2023

LGTM

@aboch aboch merged commit f1333cd into vishvananda:main Nov 27, 2023
borkmann added a commit to cilium/cilium that referenced this pull request Dec 1, 2023
Pull in recent additions to the netlink go library, that is, support
for setting TCA_FQ_PLIMIT and managing netkit driver (future work).

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: vishvananda/netlink#929
Link: vishvananda/netlink#930
borkmann added a commit to cilium/cilium that referenced this pull request Dec 1, 2023
Pull in recent additions to the netlink go library, that is, support
for setting TCA_FQ_PLIMIT and managing netkit driver (future work).

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: vishvananda/netlink#929
Link: vishvananda/netlink#930
github-merge-queue bot pushed a commit to cilium/cilium that referenced this pull request Dec 1, 2023
Pull in recent additions to the netlink go library, that is, support
for setting TCA_FQ_PLIMIT and managing netkit driver (future work).

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: vishvananda/netlink#929
Link: vishvananda/netlink#930
pjablonski123 pushed a commit to pjablonski123/cilium that referenced this pull request Dec 15, 2023
Pull in recent additions to the netlink go library, that is, support
for setting TCA_FQ_PLIMIT and managing netkit driver (future work).

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: vishvananda/netlink#929
Link: vishvananda/netlink#930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants